Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group 3] Enable nullable annotations for Microsoft.Extensions.Configuration.Tests #57422

Closed

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Aug 14, 2021

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 14, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Extensions-Configuration and removed community-contribution Indicates that the PR has been added by a community member labels Aug 14, 2021
@ghost
Copy link

ghost commented Aug 14, 2021

Tagging subscribers to this area: @maryamariyan, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Notes:

Author: maxkoshevoi
Assignees: -
Labels:

area-Extensions-Configuration

Milestone: -

@stephentoub
Copy link
Member

Thank you. We've generally not been annotating tests, in part because tests purposefully do things that violate contracts.

@maxkoshevoi
Copy link
Contributor Author

@stefannikolei Oh, got it. I've gotten some nullable errors in different test project (options something) in my other PRs, so thought, that tests should be annotated too. If it's not the case, feel free to close this one.

PS: When you'll have time, could you please review #57401? Cause I have code ready for other Configuration.Xxx projects, but they depend on abstractions, so I want to fix abstractions PR first before creating others.

@maxkoshevoi maxkoshevoi changed the title Enable nullable annotations for Microsoft.Extensions.Configuration.Tests Enable nullable annotations for Microsoft.Extensions.Configuration.Tests Aug 15, 2021
@maxkoshevoi maxkoshevoi changed the title Enable nullable annotations for Microsoft.Extensions.Configuration.Tests [Group 3] Enable nullable annotations for Microsoft.Extensions.Configuration.Tests Aug 15, 2021
@maryamariyan maryamariyan added this to the 7.0.0 milestone Aug 16, 2021
# Conflicts:
#	src/libraries/Microsoft.Extensions.Configuration/tests/Microsoft.Extensions.Configuration.Tests.csproj
@maxkoshevoi maxkoshevoi marked this pull request as draft October 7, 2021 06:03
@eerhardt
Copy link
Member

eerhardt commented Oct 8, 2021

Thanks for the PR here, @maxkoshevoi.

I'm going to close this since we don't nullable annotate our tests.

@eerhardt eerhardt closed this Oct 8, 2021
@maxkoshevoi maxkoshevoi deleted the mk/43605-configuration-tests branch October 8, 2021 14:50
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants