Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonConverter.Write/ReadAsPropertyName APIs #57302

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Add JsonConverter.Write/ReadAsPropertyName APIs #57302

merged 2 commits into from
Aug 16, 2021

Conversation

eiriktsarpalis
Copy link
Member

Fixes #46520.

@eiriktsarpalis eiriktsarpalis added this to the 6.0.0 milestone Aug 12, 2021
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpalis eiriktsarpalis self-assigned this Aug 12, 2021
@ghost
Copy link

ghost commented Aug 12, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #46520.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json
Milestone: 6.0.0

steveharter
steveharter approved these changes Aug 14, 2021
View reviewed changes
...ext.Json/src/System/Text/Json/Serialization/Converters/Collection/JsonDictionaryConverter.cs Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Show resolved Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Outdated Show resolved Hide resolved
...tem.Text.Json.Tests/Serialization/CustomConverterTests/CustomConverterTests.KeyConverters.cs Show resolved Hide resolved
...tem.Text.Json.Tests/Serialization/CustomConverterTests/CustomConverterTests.KeyConverters.cs Show resolved Hide resolved
@ghost
Copy link

ghost commented Aug 16, 2021

Hello @eiriktsarpalis!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@eiriktsarpalis eiriktsarpalis mentioned this pull request Aug 16, 2021
Closed
@eiriktsarpalis eiriktsarpalis merged commit 4723f00 into dotnet:main Aug 16, 2021
@eiriktsarpalis eiriktsarpalis deleted the feature-customkeyconverter branch August 16, 2021 16:46
thaystg added a commit to thaystg/runtime that referenced this pull request Aug 16, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_cache_debugger_…
58cffee 
…information

# By dotnet-maestro[bot] (4) and others
# Via GitHub
* origin/main: (58 commits)
  Localized file check-in by OneLocBuild Task (dotnet#57384)
  [debugger][wasm] Support DebuggerProxyAttribute (dotnet#56872)
  Account for type mismatch of `FIELD_LIST` members in LSRA (dotnet#57450)
  Qualify `sorted_table` allocation with `nothrow` (dotnet#57467)
  Rename transport packages to follow convention (dotnet#57504)
  Generate proper DWARF reg num for ARM32 (dotnet#57443)
  Enable System.Linq.Queryable and disable dotnet#50712 (dotnet#57464)
  Mark individual tests for 51211 (dotnet#57463)
  Fix Length for ReadOnlySequence created out of sliced Memory owned by MemoryManager (dotnet#57479)
  Add JsonConverter.Write/ReadAsPropertyName APIs (dotnet#57302)
  Remove workaround for dotnet/sdk#19482 (dotnet#57453)
  Do not drain HttpContentReadStream if the connection is disposed (dotnet#57287)
  [mono] Fix a few corner case overflow operations (dotnet#57407)
  make use of ports in SPN optional (dotnet#57159)
  Fixed H/3 stress server after the last Kestrel change (dotnet#57356)
  disable a failing stress test. (dotnet#57473)
  Eliminate temporary byte array allocations in the static constructor of `IPAddress`. (dotnet#57397)
  Update dependencies from https://github.com/dotnet/emsdk build 20210815.1 (dotnet#57447)
  [main] Update dependencies from mono/linker (dotnet#57344)
  Improve serializer performance (dotnet#57327)
  ...

# Conflicts:
#	src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
#	src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
#	src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
@ghost ghost locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@steveharter steveharter steveharter approved these changes

@layomia layomia Awaiting requested review from layomia

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json new-api-needs-documentation
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Allow custom converters for dictionary keys
3 participants
@eiriktsarpalis @stephentoub @steveharter