Replace all remaining pkgprojs with NuGet Pack task #56712

ViktorHofer · 2021-08-02T09:34:12Z

Fixes #53202
Fixes #31810

Baseline nuspecs are from Preview 6 packages.

Microsoft.Bcl.AsyncInterfaces: https://www.diffchecker.com/dHDpRTsa
Microsoft.Diagnostics.Tracing.EventSource.Redist: https://www.diffchecker.com/QBldP0Th
Microsoft.IO.Redist: https://www.diffchecker.com/iUg55Db5
Microsoft.Win32.Registry.AccessControl: https://www.diffchecker.com/x3EiEDfF
Microsoft.Win32.SystemEvents: https://www.diffchecker.com/r7gDrSMz
Microsoft.XmlSerializer.Generator: https://www.diffchecker.com/5N61BRx5
System.ComponentModel.Composition: https://www.diffchecker.com/SkQslgHG
System.ComponentModel.Composition.Registration: https://www.diffchecker.com/AUmSGDwB
System.Data.OleDb: https://www.diffchecker.com/bDCrVdrR
System.Diagnostics.EventLog: https://www.diffchecker.com/z5k4mxFN
System.Speech: https://www.diffchecker.com/0AhXUucw
System.Threading.Tasks.Dataflow: https://www.diffchecker.com/q0f29scj
System.Threading.Channels: https://www.diffchecker.com/n8aF0Sfk
System.Threading.AccessControl: https://www.diffchecker.com/K7ubW76f
System.Text.Encodings.Web: https://www.diffchecker.com/U5OHfuAo
System.Text.Encoding.CodePages: https://www.diffchecker.com/taLqfLdc
System.ServiceProcess.ServiceController: https://www.diffchecker.com/S2siZiyV
System.ServiceModel.Syndication: https://www.diffchecker.com/o9bb1DNS
System.Security.Permissions: https://www.diffchecker.com/OzC2k7g4
System.Security.Cryptography.Xml: https://www.diffchecker.com/Y5igQvHK
System.Security.Cryptography.ProtectedData: https://www.diffchecker.com/tj2XEExl
System.Security.Cryptography.Pkcs: https://www.diffchecker.com/fWXcxkqW
System.Runtime.CompilerServices.Unsafe: https://www.diffchecker.com/obOsWo3L
System.Runtime.Caching: https://www.diffchecker.com/IMbWg43n
System.Resources.Extensions: https://www.diffchecker.com/paVvAPij
System.Reflection.MetadataLoadContext: https://www.diffchecker.com/fqjYlyUo
System.Reflection.Metadata: https://www.diffchecker.com/mcCPfLG8
System.Reflection.Context: https://www.diffchecker.com/WCCwICsn
System.Numerics.Tensors: https://www.diffchecker.com/KgiHTcnQ
System.Net.Http.WinHttpHandler: https://www.diffchecker.com/hpEAM6wo
System.Net.Http.Json: https://www.diffchecker.com/nsaN4Frx
System.Memory.Data: https://www.diffchecker.com/KEg6BaQn
System.Management: https://www.diffchecker.com/njYNkNzz
System.IO.Ports: https://www.diffchecker.com/sBzE1K9U
runtime.native.System.IO.Ports: https://www.diffchecker.com/dtg1FYcH
runtime.linux-x64.runtime.native.System.IO.Ports: https://www.diffchecker.com/UdcZoxKh
System.IO.Pipelines: https://www.diffchecker.com/JVhrrhKC
System.Formats.Cbor: https://www.diffchecker.com/gEWsGdh7
System.Formats.Asn1: https://www.diffchecker.com/jLT8XbBY
System.Drawing.Common: https://www.diffchecker.com/Z8Az6CtB
System.DirectoryServices.Protocols: https://www.diffchecker.com/4DfXA2yB
System.DirectoryServices.AccountManagement: https://www.diffchecker.com/7tdAAbTo
System.DirectoryServices: https://www.diffchecker.com/uxJqxR9A
System.Diagnostics.DiagnosticSource: https://www.diffchecker.com/chg3lpCg
System.Text.Json: https://www.diffchecker.com/X1dSp2i3
System.Data.Odbc: https://www.diffchecker.com/veafJ5mH
System.CodeDom: https://www.diffchecker.com/U9fvE4g2
System.Collections.Immutable: https://www.diffchecker.com/KmO6gLFr
System.Configuration.ConfigurationManager: https://www.diffchecker.com/JRfDoJqY
System.IO.Packaging: https://www.diffchecker.com/hdjmjLZX

Bugs discovered while working on the PR and fixed:

Satellite assemblies weren't included for the System.Text.Json source generator
Symbol files were missing for the runtime.*.runtime.native.System.IO.Ports packages.

TODO:

Review package content (build, lib, runtimes folders and other files)
Review placeholder files (Xamarin and .NETFramework)
Review nuspec and especially the dependency nodes section
Review package baseline suppression files
Post nuspec for every library
Review the packages again but this time the ones produced in CI. Check if SourceLink works.
Decide what to do about exclude="compile"

Please review per commit

ghost · 2021-08-02T09:34:19Z

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #53202

Microsoft.Bcl.AsyncInterfaces
Microsoft.Diagnostics.Tracing.EventSource.Redist
Microsoft.IO.Redist
Microsoft.Win32.Registry.AccessControl
Microsoft.Win32.SystemEvents
Microsoft.XmlSerializer.Generator
System.ComponentModel.Composition
System.ComponentModel.Composition.Registrat
System.Data.OleDb
System.Diagnostics.EventLog

Please review per commit

Author:	ViktorHofer
Assignees:	-
Labels:	`area-Infrastructure-libraries`
Milestone:	-

eng/packaging.targets

safern · 2021-08-02T18:36:37Z

src/libraries/Microsoft.Bcl.AsyncInterfaces/src/CompatibilitySuppressions.xml

+  <Suppression>
+    <DiagnosticId>CP0001</DiagnosticId>
+    <Target>T:System.IAsyncDisposable</Target>
+    <Left>lib/netstandard2.0/Microsoft.Bcl.AsyncInterfaces.dll</Left>


Do you know why are we hitting these? Why did lib/netstandard2.1 asset removed all these types?

TypeForwards are still missing from the validation.

netstandard2.1 is just a facade:

runtime/src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj

Line 6 in 0ea6d0c

<IsPartialFacadeAssembly Condition="'$(TargetFramework)' == 'netstandard2.1'">true</IsPartialFacadeAssembly>

safern · 2021-08-02T18:38:15Z

src/libraries/Microsoft.Win32.SystemEvents/src/CompatibilitySuppressions.xml

+    <DiagnosticId>CP0001</DiagnosticId>
+    <Target>T:Microsoft.Win32.PowerModeChangedEventArgs</Target>
+    <Left>lib/netstandard2.0/Microsoft.Win32.SystemEvents.dll</Left>
+    <Right>lib/net461/Microsoft.Win32.SystemEvents.dll</Right>


I suspect these are because of typeforwards. We could simplify this suppressions file by just adding a "global" suppression for this tuple, without a specific target API. i.e:

<?xml version="1.0"?> <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> <Suppression> <DiagnosticId>CP0001</DiagnosticId> <Left>lib/netstandard2.0/Microsoft.Win32.SystemEvents.dll</Left> <Right>lib/net461/Microsoft.Win32.SystemEvents.dll</Right> </Suppression> </Suppressions>

Same for all other suppression files where we want to suppress this diagnostic ID for all types in a specific tuple.

The PackageValidation used has the change but it doesn't work.

<?xml version="1.0" encoding="utf-8"?> <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> <Suppression> <DiagnosticId>CP0001</DiagnosticId> <Left>lib/netstandard2.0/System.IO.Ports.dll</Left> <Right>lib/net461/System.IO.Ports.dll</Right> </Suppression> </Suppressions>

C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Handshake' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Parity' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialData' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialError' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChange' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPort' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.StopBits' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Handshake' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Parity' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialData' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialError' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChange' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPort' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.StopBits' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Handshake' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Parity' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialData' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialError' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChange' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPort' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.StopBits' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Handshake' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Parity' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialData' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialError' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChange' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPort' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.StopBits' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Handshake' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Parity' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialData' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialError' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChange' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPort' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.StopBits' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Handshake' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.Parity' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialData' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialDataReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialError' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialErrorReceivedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChange' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventArgs' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPinChangedEventHandler' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.SerialPort' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj] C:\Users\vihofer\.nuget\packages\microsoft.dotnet.packagevalidation\1.0.0-rc.1.21376.22\build\Microsoft.DotNet.PackageValidation.targets(22,5): error CP0001: Type 'System.IO.Ports.StopBits' exists on runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll but not on lib/net461/System.IO.Ports.dll [C:\git\runtime3\src\libraries\System.IO.Ports\src\System.IO.Ports.csproj]

I see another left listed on the errors, that is comparing the Unix runtime for ns2.0 agains the net461 lib.

Is that a bug in PackageValidation or in the System.IO.Ports package?

@Anipik is the comparison of those two assets expected? Having the runtime asset at the left compared against the net461 lib?

It is weird that the package has a ns2.0/Unix runtime asset, netstandard assets should be rid agnostic and the rid specific assets should target NETCoreApp. @ericstj is that correct?

It's fine to have a RID-specific netstandard asset. That just means that the managed surface area used by the library can be satisfied by netstandard, but it needed to depend on some platform specific API.

I do find it odd that PackageValidation is asserting that runtimes/unix/lib/netstandard2.0 asset needs to be compatible with lib/net461 that seems like a bug.

I do find it odd that PackageValidation is asserting that runtimes/unix/lib/netstandard2.0 asset needs to be compatible with lib/net461 that seems like a bug.

Yeah that seems pretty weird.

It seems like this was fixed with the latest package.

src/libraries/System.ServiceProcess.ServiceController/src/CompatibilitySuppressions.xml

src/libraries/System.Speech/src/System.Speech.csproj

Anipik · 2021-08-02T22:11:17Z

Just couple diffs i noticed

some package references have exclude="Compile" before and not after the change eg system.Memory in System.Diagnostics.eventLog
some dependencies are getting added in system.relection.context & S.R.MetaDataLoadContext for net6.0

ViktorHofer · 2021-08-03T14:19:14Z

@ericstj looks like System.Text.Json is missing satellite assemblies. Intentionally?

(left = old, right = new)

ericstj · 2021-08-03T14:30:20Z

Right side is correct. Satellite assemblies should be included.

ViktorHofer · 2021-08-03T15:30:15Z

Thanks for the feedback @Anipik

some dependencies are getting added in system.relection.context & S.R.MetaDataLoadContext for net6.0

Added dependencies for .NETCoreApp are expected as we don't trim them out anymore if the exact reference is already supplied by the shared framework. That was a feature in the pkgproj system which looked at assembly references vs. NuGet which uses ProjectReferences and PackageReferences emitted into the project.assets.json file to calculate depenencies. That behavior change is understood and fine.

some package references have exclude="Compile" before and not after the change eg system.Memory in System.Diagnostics.eventLog

I'm not yet sure what to do about those. I don't yet know how the pkgproj system handled those and how much we care keeping those excludes. @ericstj can you share some details about that?

ViktorHofer · 2021-08-04T18:35:08Z

OH WOW, I didn't expect that. BuildAllConfiguration leg + package testing in it completed successfully 🎉🎉🎉

ericstj

I didn't see anything blocking on review of diffs / targets. I'm OK to merge when green

ericstj · 2021-08-04T20:23:54Z

src/libraries/System.Security.Permissions/src/CompatibilitySuppressions.xml

+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0008</DiagnosticId>


This is different, but another one related to missing dependencies. NamedPermissionSet derives from PermissionSet which is part of System.Runtime. This might be interesting to look at @safern. One thing I notice is that the suppression doesn't list the interface that was removed, which means it will suppress all removals. Another thing that surprised me was that we should be able to identify that the interface is still present with the exact same name, we just couldn't be certain if it would resolve to the same definition as the one defined in netstandard.dll. I wonder if we want to tolerate that, or give it a different diagnostic?

One thing I notice is that the suppression doesn't list the interface that was removed, which means it will suppress all removals.

Good catch! Should we maybe set the target to include the interface that is removed somehow?

This is different, but another one related to missing dependencies

I'll take a look at this specific scenario and see if we should consider running this rule only when we have dependencies.

Do you want to track this discussion in an issue so that it doesn't get lost?

eng/packaging.targets

ViktorHofer · 2021-08-05T05:45:41Z

So I'm going to merge this beast in when CI is green. The suppression files are now cleaned up, no 5k+ line additions anymore and instead being true to myself by deleting more lines than adding in the PR 😄.

safern · 2021-08-05T07:35:40Z

src/libraries/System.IO.Ports/src/CompatibilitySuppressions.xml

+    <DiagnosticId>CP0001</DiagnosticId>
+    <Target>T:System.IO.Ports.Parity</Target>
+    <Left>lib/net461/System.IO.Ports.dll</Left>
+    <Right>runtimes/unix/lib/netstandard2.0/System.IO.Ports.dll</Right>


@Anipik we should really look into this, I can't understand why we are comparing a net461 asset as a compile asset against a Unix runtime specific asset.

When I talked with @Anipik yesterday he mentioned that this might be a NuGet bug when calling into their APIs.

Do we have an issue opened yet? Can we workaround it?

@Anipik is the expert on this. I'll defer to him.

ViktorHofer · 2021-08-05T09:02:45Z

Failures:

runtime (Libraries Test Run release coreclr windows x86 Debug): FileStream_WriteAsync_AsyncWrites.WriteAsyncCancelledFile test failed #56894

Timeouts:

Runtime (Libraries Build OSX x64 Debug): The machine just became super slow while building the normal set of libraries. Not actionable.

I incorrectly added it back while resolving merge conflicts in dotnet#56719 but it was removed from global.json with dotnet#56712

I incorrectly added it back while resolving merge conflicts in #56719 but it was removed from global.json with #56712

ViktorHofer requested a review from Anipik August 2, 2021 09:34

dotnet-issue-labeler bot added the area-Infrastructure-libraries label Aug 2, 2021

ViktorHofer mentioned this pull request Aug 2, 2021

Port projects from pkgproj to dotnet pack #53202

Closed

58 tasks

ViktorHofer force-pushed the PkgProjMoveCsProjNext branch from 78acc24 to 6c2e0fd Compare August 2, 2021 12:57

ViktorHofer changed the title ~~Port pkgprojs to use NuGet Pack task~~ Replace pkgprojs with NuGet Pack task Aug 2, 2021

ViktorHofer force-pushed the PkgProjMoveCsProjNext branch 4 times, most recently from 86f99ff to 165211b Compare August 2, 2021 16:08