[icall] If Stream:BeginWrite/EndWrite are linked out, they're not overridden #56559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: Issue DetailsAdd the same logic that we already have for BeginRead/EndRead - if we can't find a vtable slot that has the method in the base class, it must have been linked out, so a subclass can't possibly override it. Fixes #56315
|
vargaz
approved these changes
Jul 29, 2021
…rridden Add the same logic that we already have for BeginRead/EndRead - if we can't find a vtable slot that has the method in the base class, it must have been linked out, so a subclass can't possibly override it. Fixes dotnet#56315
This was referenced Jul 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the same logic that we already have for BeginRead/EndRead - if we can't find a vtable slot that has the method in the base class, it must have been linked out, so a subclass can't possibly override it.
Fixes #56315