Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull in new Helix Fedora image #56429

Merged
merged 2 commits into from
Jul 29, 2021
Merged

pull in new Helix Fedora image #56429

merged 2 commits into from
Jul 29, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 27, 2021 •
edited
Loading

This updates Fedora image to bring new MsQuic dotnet/dotnet-buildtools-prereqs-docker#488 and dotnet/dotnet-buildtools-prereqs-docker#483

contributes to: dotnet/core#6431
contributes to #55746
contributes to #55242

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@wfurt wfurt requested review from a team and safern July 29, 2021 00:32
@wfurt wfurt self-assigned this Jul 29, 2021
@ghost
Copy link

ghost commented Jul 29, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

smoke run

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic
Milestone: -

@wfurt wfurt marked this pull request as ready for review July 29, 2021 00:33
@wfurt
Copy link
Member Author

wfurt commented Jul 29, 2021

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-56429-merge-958c0d635a1e4a8886/System.Net.Quic.Functional.Tests/console.e9b7e226.log?sv=2019-07-07&se=2021-08-17T19%3A06%3A39Z&sr=c&sp=rl&sig=tAn%2BiYGvStWAw7f0cT%2FN9hCilEa5uXeN1Cr5yzD46Bw%3D

/root/helix/work/workitem /root/helix/work/workitem
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 108 of 129 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 514, Errors: 0, Failed: 0, Skipped: 0, Time: 26.383s

Quic finished with 514 so MsQuic should be included.

@wfurt wfurt merged commit 171a1f0 into dotnet:main Jul 29, 2021
safern
safern reviewed Jul 29, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt mentioned this pull request Jul 29, 2021
Merged
karelz pushed a commit that referenced this pull request Jul 30, 2021
@wfurt
Enable disabled QUIC tests (#56590)
38071bf 
With update updated MsQuic on Linux in place (PR #56429) we should pass few more disabled tests.
I did ~200 local runs and I did not see any problems

Fixes #55242
Fixes #55746
@wfurt wfurt mentioned this pull request Jul 30, 2021
Merged
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern left review comments

@karelz karelz karelz approved these changes

Assignees

@wfurt wfurt

Labels
area-System.Net.Quic
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wfurt @karelz @safern