Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change reading time zone display names #56171

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Change reading time zone display names #56171

merged 2 commits into from
Jul 23, 2021

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 22, 2021

Fixes #55307

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2021

@mattjohnsonpint could you please have a look?

CC @safern

@tarekgh tarekgh self-assigned this Jul 22, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #55307

Author: tarekgh
Assignees: -
Labels:

area-System.Runtime
Milestone: -

@tarekgh tarekgh added this to the 6.0.0 milestone Jul 22, 2021
@tarekgh tarekgh force-pushed the ChangeHowWeReadTimeZoneDisplayName branch from 0ebdcc5 to d6512b7 Compare July 22, 2021 23:22
@tarekgh
Copy link
Member Author

tarekgh commented Jul 23, 2021

The CI failures are no related. #56190

@tarekgh tarekgh merged commit 0bd7ddc into dotnet:main Jul 23, 2021
@tarekgh tarekgh deleted the ChangeHowWeReadTimeZoneDisplayName branch July 23, 2021 16:36
@AntonLapounov
Copy link
Member

Thank you for fixing this!

@ghost ghost locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@AntonLapounov AntonLapounov AntonLapounov left review comments

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

@safern safern safern approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.DateTime
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Calling DateTime.Now causes memory corruption when machine has many language packs installed
6 participants
@tarekgh @AntonLapounov @mattjohnsonpint @stephentoub @safern @jeffhandley