-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0-preview7] Eliminate backtracking in the interpreter for patterns with .* #55960
[release/6.0-preview7] Eliminate backtracking in the interpreter for patterns with .* #55960
Conversation
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions |
This is approved to merge. The test failure is unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matches main.
Hello @danmoseley! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
FYI, this change (in RC1) likely broke some tests in ASP.NET Core dotnet/aspnetcore#34491 Looking into the previous and current behavior, will post in a couple minutes the results. |
Rule: Expected backreferences:
Actual backreferences: None, didn't match @danmoseley @safern @pgovind I don't think this was intended to be a breaking change |
It was not. This should be reverted. On .NET 5, |
It was not. I think I see the problem. Let's revert this change for now |
Backport of #51508 to release/6.0-preview7
/cc @pgovind
Customer Impact
.*
in them. In my performance tests (part of the original PR), I get a speed up of 6xTesting
.*
and various patterns (strings/numbers/case sensitivity/RightToLeft).*
patternRisk