Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] disabled test #55912

Merged
merged 1 commit into from
Jul 19, 2021
Merged

[QUIC] disabled test #55912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ public async Task SendStreamLimitRequestsConcurrently_Succeeds(int streamLimit)
[InlineData(10)]
[InlineData(100)]
[InlineData(1000)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55901")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue says only about limit=10 -- is it also failing for other limits?

Copy link
Member Author

@ManickaP ManickaP Jul 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's on purpose here from my experience with how mocks behaved. If I disabled one, it started to fail on the next input value. So I'd rather be on the safe side and disable them all at once.
Do you think it's worthwhile to disable just one input and see if it starts appearing on other inputs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. If it's affecting others a lot I guess it's better better to be on the safe side. However, I was sure that all the inputs are run even if one of them fails...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they do run.
What I'll say know will sound super proffesionally 😄 but what happened with mocks was that always the first call failed (timed out) and the subsequent passed, no matter what you disabled/enabled. They shouldn't have affect each other, since the connection is always new etc., but that's what I was seeing and eventually gave up investigating.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable it only on mock if there is way how to detect it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mocks has been disabled for a while, now we have a failure on msquic (for which this PR is).
Since I had a bad experience with trying to disable just one input on mock (always leading to failure one step further), I'm preemptively disabling them all here. That's what this discussion was about.

public async Task SendMoreThanStreamLimitRequestsConcurrently_LastWaits(int streamLimit)
{
// This combination leads to a hang manifesting in CI only. Disabling it until there's more time to investigate.
Expand Down