Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the calculation method of Days field #55882

Closed
wants to merge 1 commit into from

Conversation

weibaohui
Copy link

Fix the calculation method of Days field

Fix the calculation method of Days field
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@stephentoub
Copy link
Member

stephentoub commented Jul 18, 2021

Thanks, but the current implementation is correct. The difference between Days and TotalDays, per the documentation, is simply whether its counting whole or fractional. Days is not meant to wrap around at 365.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants