Compression.ZipFile support for Unix Permissions #55531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on Unix, capture the file's permissions on ZipFile Create and write the captured file permissions on ZipFile Extract. Fix dotnet#1548
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsWhen running on Unix, capture the file's permissions on ZipFile Create and write the captured file permissions on ZipFile Extract. Fix #1548 Draft: Still need to add tests.
|
stephentoub
reviewed
Jul 12, 2021
...IO.Compression.ZipFile/src/System/IO/Compression/ZipFileExtensions.ZipArchive.Create.Unix.cs
Show resolved
Hide resolved
|
@lewing @radical @ViktorHofer @safern - UPDATE: Fixed by adding a Browser TFM to the project. |
stephentoub
reviewed
Jul 13, 2021
src/libraries/System.IO.Compression.ZipFile/src/System.IO.Compression.ZipFile.csproj
Show resolved
Hide resolved
stephentoub
reviewed
Jul 13, 2021
...IO.Compression.ZipFile/src/System/IO/Compression/ZipFileExtensions.ZipArchive.Create.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 13, 2021
...pression.ZipFile/src/System/IO/Compression/ZipFileExtensions.ZipArchiveEntry.Extract.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 13, 2021
src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Show resolved
Hide resolved
stephentoub
reviewed
Jul 13, 2021
stephentoub
approved these changes
Jul 13, 2021
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jul 14, 2021
…debugger_custom_views * 'main' of github.com:thaystg/runtime: (125 commits) [wasm] [debugger] Support method calls (dotnet#55458) [debugger] Fix debugging after hot reloading (dotnet#55599) Inliner: Extend IL limit for profiled call-sites, allow inlining for switches. (dotnet#55478) DiagnosticSourceEventSource supports base class properties (dotnet#55613) [mono] Fix race during mono_image_storage_open (dotnet#55201) [mono] Add wrapper info for native func wrappers. (dotnet#55602) H/3 and Quic AppContext switch (dotnet#55332) Compression.ZipFile support for Unix Permissions (dotnet#55531) [mono] Fix skipping of static methods during IMT table construction. (dotnet#55610) Combine System.Private.Xml TrimmingTests projects (dotnet#55606) fix name conflict with Configuration class (dotnet#55597) Finish migrating RSAOpenSsl from RSA* to EVP_PKEY* Disable generic math (dotnet#55540) Obsolete CryptoConfig.EncodeOID (dotnet#55592) Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp (dotnet#54995) Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled (dotnet#55572) Fix Task.WhenAny failure mode when passed ICollection of zero tasks (dotnet#55580) Consume DistributedContextPropagator in DiagnosticsHandler (dotnet#55392) Add property ordering feature (dotnet#55586) Reduce subtest count in Reflection (dotnet#55537) ...
ntsim
added a commit
to dfe-analytical-services/explore-education-statistics
that referenced
this pull request
Aug 17, 2021
Currently, .NET doesn't automatically add Unix file permissions to our zip's file entries. This means that all of the files cannot be opened without setting the permissions manually in the OS. To fix this, we manually add the Unix file permissions ourselves by converting a permission string to an octal literal on the zip entry. I believe that in .NET 6, this should be done automatically for us due to the following change: dotnet/runtime#55531
ntsim
added a commit
to dfe-analytical-services/explore-education-statistics
that referenced
this pull request
Aug 17, 2021
Currently, .NET doesn't automatically add Unix file permissions to our zip's file entries. This means that all of the files cannot be opened without setting the permissions manually in the OS. To fix this, we manually add the Unix file permissions ourselves by converting a permission string to an octal literal on the zip entry. I believe that in .NET 6, this should be done automatically for us due to the following change: dotnet/runtime#55531
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on Unix, capture the file's permissions on ZipFile Create and write the captured file permissions on ZipFile Extract.
Fix #1548