Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Connect_DualMode_DnsConnect_RetrievedEndPoints_Success on Linux #54681

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Fix Connect_DualMode_DnsConnect_RetrievedEndPoints_Success on Linux #54681

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c095769
Update Connect.cs
antonfirsov Jun 24, 2021
94a50aa
Fix the test instead of disabling.
antonfirsov Jun 24, 2021
dbd2b61
use .Equals(), == is not overriden
antonfirsov Jun 24, 2021
72c3f12
Update src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs
antonfirsov Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ public async Task Connect_DualMode_MultiAddressFamilyConnect_RetrievedEndPoints_
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/54677", TestPlatforms.Linux)]
Copy link
Member

@tmds tmds Jun 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonfirsov can you update the test so both IPAddress.Loopback.MapToIPv6() and IPAddress.IPv6Loopback are allowed for localEndPoint.Address?

I expect for remoteEndPoint.Address we should stick to IPAddress.Loopback.MapToIPv6() only because the test server is bound to IPAddress.Loopback.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I overlooked the exception message, and for some reason thought LocalEndPoint was IPv4, not ::1.
Makes sense to fix the test instead of disabling.

public async Task Connect_DualMode_DnsConnect_RetrievedEndPoints_Success()
{
var localhostAddresses = Dns.GetHostAddresses("localhost");
Expand Down