-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0-preview6] [wasm] Build static components; include hot_reload in runtime #54622
[release/6.0-preview6] [wasm] Build static components; include hot_reload in runtime #54622
Conversation
Workaround until #54565 is fixed Build the runtime always with support for hot_reload, and without diagnostics_tracing
Just check that the capabilities are non-empty which is a good proxy for hot reload being enabled in the runtime.
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #54568 to release/6.0-preview6 /cc @lambdageek Customer ImpactFixes a regression (compared to .NET 6 Preview 5) that disabled hot reload support for Blazor WebAssembly in .NET 6 Preview 6. Without this PR, TestingNew functional test in dotnet/runtime that validates that hot reload support is enabled and that applying updates works. RiskLow - .NET 6 Preview 5 had working hot reload support.
|
The new test is failing because it looks like the wasm configuration changed between preview 6 and main |
Updated the test to use the older mechanism. verified locally that the test runs and passes |
Servicing-approved by SCarroll over email |
@mmitche any timeline on when this can be merged? |
Merge when ready. |
Backport of #54568 to release/6.0-preview6
/cc @lambdageek
Customer Impact
Fixes a regression (compared to .NET 6 Preview 5) that disabled hot reload support for Blazor WebAssembly in .NET 6 Preview 6. Without this PR,
dotnet-watch
hot reload will not work for Blazor WebAssembly projects. As a workaround, customers could continue to usedotnet build
anddotnet run
to iterate on their work.Testing
New functional test in dotnet/runtime that validates that hot reload support is enabled and that applying updates works.
Risk
Low - .NET 6 Preview 5 had working hot reload support - this PR just re-enables a disabled component