[wasm] browser http response stream could be seekable #54603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An additional test for when |
stephentoub
approved these changes
Jun 23, 2021
lewing
approved these changes
Jun 24, 2021
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
Outdated
Show resolved
Hide resolved
radekdoulik
reviewed
Jun 24, 2021
| @@ -969,21 +968,24 @@ public async Task ReadAsStreamAsync_HandlerProducesWellBehavedResponseStream(boo | |||
| // Boolean properties returning correct values | |||
| Assert.True(responseStream.CanRead); | |||
| Assert.False(responseStream.CanWrite); | |||
| Assert.False(responseStream.CanSeek); | |||
| Assert.Equal(PlatformDetection.IsBrowser, responseStream.CanSeek); | |||
There was a problem hiding this comment.
Do we want this check after all? Hypothetically, when there's new platform with response stream that can seek as well, this line would need an update again. Or does it has some other purpose here?
|
@pavelsavara it seems that this PR has broken the full Framework build ( |
|
thanks Adam, I missed both the build failure and the #IF. |
|
Revert #54742 |
pavelsavara
added a commit
that referenced
this pull request
Jun 25, 2021
|
Next attempt in #54749 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, the unit test is too restrictive.
Fixes #54159