Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the metadata update related APIs to the MetadataUpdater class #54590

Merged
merged 6 commits into from
Jun 25, 2021
Merged

Move the metadata update related APIs to the MetadataUpdater class #54590

merged 6 commits into from
Jun 25, 2021

Commits on Jun 24, 2021

  1. Move the metadata update related APIs to the MetadataUpdater class 

    The old APIs AssemblyExtensions.ApplyUpdate() and AssemblyExtensions.GetApplyUpdateCapabilities() will be removed
after all the references to them have been changed to the new APIs.

Add the new IsSupported API described in issue dotnet#51159.

Change the tests to use the MetadataUpdater APIs.
    @mikem8361
    mikem8361 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    72bc435 View commit details
    Browse the repository at this point in the history

  2. Code review feedback 

    Fix the ApplyUpdate qcalls and icalls

Add the ILLink substitutions for MetadataUpdater.IsSupported property

Change the old APIs to call the new ones
    @mikem8361
    mikem8361 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    94ed51a View commit details
    Browse the repository at this point in the history

  3. Update mono's MetadataUpdater.IsSupported property

    @mikem8361
    mikem8361 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    d8e5ccb View commit details
    Browse the repository at this point in the history

  4. Update feature switch doc

    @mikem8361
    mikem8361 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    b4cd895 View commit details
    Browse the repository at this point in the history

  5. Code review feedback. Making the new MetadataUpdater.GetCapabilities(… 

    …) internal.

Fixed the argument checking in coreclr's MetadataUpdater.ApplyUpdate().
    @mikem8361
    mikem8361 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    fa0b55d View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Code review feedback.

    @mikem8361
    mikem8361 committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    caa69d6 View commit details
    Browse the repository at this point in the history