Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name of corrupted certificate to CryptographicException on Mac #54477

Merged
merged 6 commits into from
Jun 21, 2021
Merged

Add name of corrupted certificate to CryptographicException on Mac #54477

merged 6 commits into from
Jun 21, 2021

Commits on Jun 21, 2021

  1. Add name of corrupted certificate to CryptographicException on Mac 

    When trying to create a CertificateData out of raw X509 byte array it might throw if the data is corrupted. The existing exception message does not provide any information which might help the user identify the corrupted certificate and fix it.

This change, makes a native call to SecCertificateCopySubjectSummary which will provide a human readable summary of the certificate, and will generate an exception message using this string.

fix dotnet#54336
    @odhanson
    odhanson committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    37ed2e0 View commit details
    Browse the repository at this point in the history

  2. Allow subjectSummary to be null

    @odhanson
    odhanson committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e9cac27 View commit details
    Browse the repository at this point in the history

  3. Update src/libraries/System.Security.Cryptography.X509Certificates/sr… 

    …c/Internal/Cryptography/Pal.OSX/AppleCertificatePal.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
    @odhanson @bartonjs
    odhanson and bartonjs committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    51ecae3 View commit details
    Browse the repository at this point in the history

  4. Update src/libraries/System.Security.Cryptography.X509Certificates/sr… 

    …c/Internal/Cryptography/Pal.OSX/AppleCertificatePal.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
    @odhanson @bartonjs
    odhanson and bartonjs committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    33641fe View commit details
    Browse the repository at this point in the history

  5. Fixed using

    @odhanson
    odhanson committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    6057f2b View commit details
    Browse the repository at this point in the history

  6. Fixed stuff

    @odhanson
    odhanson committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    6b82199 View commit details
    Browse the repository at this point in the history