Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more LDAP TLS tests on linux #54377

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Enable more LDAP TLS tests on linux #54377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f479cda
Remove SupportedOsPlatform attribute for LDAP TLS
iinuwa Jun 17, 2021
5eb85d6
Throw ObjectDisposedException when setting LDAP TLS settings on Linux.
iinuwa Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ...ervices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Linux.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,21 @@ public partial class LdapSessionOptions
{
private static void PALCertFreeCRLContext(IntPtr certPtr) { /* No op */ }

public bool SecureSocketLayer { get; set; }
private bool _secureSocketLayer;

public bool SecureSocketLayer
krwq marked this conversation as resolved.
Show resolved Hide resolved
{
get
{
if (_connection._disposed) throw new ObjectDisposedException(GetType().Name);
return _secureSocketLayer;
}
set
{
if (_connection._disposed) throw new ObjectDisposedException(GetType().Name);
_secureSocketLayer = value;
}
}

public int ProtocolVersion
{
Expand Down
1 change: 0 additions & 1 deletion ...vices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ public partial class LdapSessionOptions
{
private static void PALCertFreeCRLContext(IntPtr certPtr) => Interop.Ldap.CertFreeCRLContext(certPtr);

[SupportedOSPlatform("windows")]
public bool SecureSocketLayer
{
get
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.DirectoryServices.Protocols/tests/LdapSessionOptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ public void SecureSocketLayer_Set_GetReturnsExpected(bool value)
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)]
public void SecureSocketLayer_GetSetWhenDisposed_ThrowsObjectDisposedException()
{
var connection = new LdapConnection("server");
Expand Down