Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PosixSignal API #54136

Merged
merged 65 commits into from
Jul 8, 2021
Merged

Implement PosixSignal API #54136

merged 65 commits into from
Jul 8, 2021

Commits on Jun 21, 2021

  1. Implement PosixSignal API

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    11a94bb View commit details
    Browse the repository at this point in the history

  2. PosixSignalRegistration: implement finalizer

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    ae4d67e View commit details
    Browse the repository at this point in the history

  3. Support using positive PosixSignal values as raw signal numbers

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    72a2475 View commit details
    Browse the repository at this point in the history

  4. Reduce nr of TargetFrameworks

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    17045d8 View commit details
    Browse the repository at this point in the history

  5. #ifdef SIGRTMAX

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    61a0fba View commit details
    Browse the repository at this point in the history

  6. Don't throw Win32Exception (for now)

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    b5ae07a View commit details
    Browse the repository at this point in the history

  7. Rename PosixSignalRegistration.cs to PosixSignalRegistration.Unsuppor… 

    …ted.cs
    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    52e1f17 View commit details
    Browse the repository at this point in the history

  8. Spawn new Thread only for specific signals

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    26f22b3 View commit details
    Browse the repository at this point in the history

  9. Add PosixSignal.SIGCONT, SIGWINCH, SIGTTIN, SIGTTOU, SIGTSTP

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    0bd03f9 View commit details
    Browse the repository at this point in the history

  10. SystemNative_DefaultSignalHandler: remove SuppressGCTransition attribute

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e8d01c8 View commit details
    Browse the repository at this point in the history

  11. Update comment in SystemNative_InitializeTerminalAndSignalHandling

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    6cc2d89 View commit details
    Browse the repository at this point in the history

  12. Run original handler except for cancelable signals.

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    5892f0d View commit details
    Browse the repository at this point in the history

  13. Cleanup ControlCHandlerRegistrar

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f337677 View commit details
    Browse the repository at this point in the history

  14. Handle TryGetTarget returning false due to finalized PosixSignalRegis… 

    …trations
    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    c3dce04 View commit details
    Browse the repository at this point in the history

  15. Use Thread.UnsafeStart

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    db75bba View commit details
    Browse the repository at this point in the history

  16. Remove SuppressGCTransition from methods that take a lock

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    96ded59 View commit details
    Browse the repository at this point in the history

  17. Support canceling terminal configuration on SIGCHLD/SIGCONT

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    55f1abe View commit details
    Browse the repository at this point in the history

  18. Throw for errno using Interop.CheckIO

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    7a2594c View commit details
    Browse the repository at this point in the history

  19. Rename DefaultSignalHandler to HandleNonCanceledPosixSignal

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    9c27d6e View commit details
    Browse the repository at this point in the history

  20. Register Console SIGTTOU with SA_RESETHAND

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    b5ed74d View commit details
    Browse the repository at this point in the history

  21. Allocate storage for tracking signals dynamically

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    76b8704 View commit details
    Browse the repository at this point in the history

  22. Propagate sigaction errors when enabling PosixSignal

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    5f5deb3 View commit details
    Browse the repository at this point in the history

  23. Add some tests

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    03c03b8 View commit details
    Browse the repository at this point in the history

  24. Fix entrypoints

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    6f0c69b View commit details
    Browse the repository at this point in the history

  25. Fix compilation

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d873120 View commit details
    Browse the repository at this point in the history

  26. Add some more tests

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    bc1590c View commit details
    Browse the repository at this point in the history

  27. Move tests to PosixSignalRegistrationTests.Unix file

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e8827ce View commit details
    Browse the repository at this point in the history

  28. Add SignalCanCancelTermination test

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    511f604 View commit details
    Browse the repository at this point in the history

  29. ConfigureTerminalForChildProcesses: split Unix and iOS

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    1d15e42 View commit details
    Browse the repository at this point in the history

  30. Fix iOS compilation failure

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    a760612 View commit details
    Browse the repository at this point in the history

  31. Skip signals that cause xunit to exit with non zero

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    dddc5bc View commit details
    Browse the repository at this point in the history

  32. Try fix Android compilation

    @tmds
    tmds committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d4c8e24 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Remove SIGSTOP from UninstallableSignalsThrow because it doesn't thro… 

    …w on OSX
    @tmds
    tmds committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    12150ab View commit details
    Browse the repository at this point in the history

  2. Cleanup

    @tmds
    tmds committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    469b6fe View commit details
    Browse the repository at this point in the history

  3. Handle case where all handlers got disposed by the time we want to ca… 

    …ll them.
    @tmds
    tmds committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    38a4d76 View commit details
    Browse the repository at this point in the history

  4. GenerateReferenceAssemblySource

    @tmds
    tmds committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    8841d41 View commit details
    Browse the repository at this point in the history

  5. Replace PosixSignalRegistration.Unsupported with .Windows/.Browser file

    @tmds
    tmds committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c2ef9eb View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Remove assert(g_hasTty) from UninitializeTerminal

    @tmds
    tmds committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    575dd7d View commit details
    Browse the repository at this point in the history

  2. Initialize signal handling when ifndef HAS_CONSOLE_SIGNALS

    @tmds
    tmds committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    3756ac2 View commit details
    Browse the repository at this point in the history

  3. Fix broken Cancel

    @tmds
    tmds committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    778350f View commit details
    Browse the repository at this point in the history

  4. Use SIGRTMAX as highest usable signal number.

    @tmds
    tmds committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    ed39929 View commit details
    Browse the repository at this point in the history

  5. SIGRTMAX is not defined on all platforms, fall back to NSIG

    @tmds
    tmds committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    3c02835 View commit details
    Browse the repository at this point in the history

  6. Resend signal only when restored to SIG_DFL

    @tmds
    tmds committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    8ccfd3e View commit details
    Browse the repository at this point in the history

  7. SignalCanCancelTermination test: increase timeout

    @tmds
    tmds committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    481f40e View commit details
    Browse the repository at this point in the history

  8. Increase timeout to 10min

    @tmds
    tmds committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    669e09f View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Update expected SIGQUIT exit code for mono

    @tmds
    tmds committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    2cb8cda View commit details
    Browse the repository at this point in the history

  2. Change isMono check

    @tmds
    tmds committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    459f3e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Use PlatformDetection.IsMonoRuntime

    @tmds
    tmds committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    834350f View commit details
    Browse the repository at this point in the history

  2. Add IsSignalThatTerminates method

    @tmds
    tmds committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    c8cb449 View commit details
    Browse the repository at this point in the history

  3. Add some documentation xml

    @tmds
    tmds committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    cba68f3 View commit details
    Browse the repository at this point in the history

  4. Console.ManualTests: test terminal echo during and after child proces… 

    …s used terminal.
    @tmds
    tmds committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    19d30d6 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Maintain flags and mask of original handler

    @tmds
    tmds committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    e4cef47 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @tmds
    tmds committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    aa549a3 View commit details
    Browse the repository at this point in the history

  3. SystemNative_HandleNonCanceledPosixSignal: update handling based on d… 

    …efault dispositions.
    @tmds
    tmds committed Jun 30, 2021
    1 Configuration menu
    Copy the full SHA
    324db13 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @tmds @stephentoub
    tmds and stephentoub committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    8e830fe View commit details
    Browse the repository at this point in the history

  2. Don't call sa_sigaction/sa_handler twice from SystemNative_HandleNonC… 

    …anceledPosixSignal.
    @tmds
    tmds committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    85439d6 View commit details
    Browse the repository at this point in the history

  3. Don't remove WeakReferences while iterating.

    @tmds
    tmds committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    b8a0b5d View commit details
    Browse the repository at this point in the history

  4. Move static fields to the top of the class

    @tmds
    tmds committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    18b7139 View commit details
    Browse the repository at this point in the history

  5. Remove -Wcast-qual ignore

    @tmds
    tmds committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    d136c5b View commit details
    Browse the repository at this point in the history

  6. PosixSignalContext: add XML docs

    @tmds
    tmds committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    be93c17 View commit details
    Browse the repository at this point in the history

  7. Fix Android compilation

    @tmds
    tmds committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    4de318a View commit details
    Browse the repository at this point in the history

  8. Fix Android compilation, take II

    @tmds
    tmds committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    6898402 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Fix comment 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @tmds @stephentoub
    tmds and stephentoub committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    b8234bd View commit details
    Browse the repository at this point in the history

  2. Add PosixSignalContext constructor test

    @tmds
    tmds committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    f1aee19 View commit details
    Browse the repository at this point in the history

  3. SystemNative_HandleNonCanceledPosixSignal: add SIG_IGN case

    @tmds
    tmds committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    005cddd View commit details
    Browse the repository at this point in the history