Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the async local just before execution #54133

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Set the async local just before execution #54133

merged 2 commits into from
Jun 14, 2021

Commits on Jun 14, 2021

  1. Set the async local just before execution. 

    - Subscribing to DiagnosticListener.AllListeners replays all created DiagnosticListener instances. Because of this, we need to set the async local just before the execution of the entry point so that we only collect the events that are relevant to the call. Right now, it's also firing with the async local set pre-maturely.
- Wrote a concurrency test to make sure it's safe to instantiate the factory in parallel.
    @davidfowl
    davidfowl committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    8558b1c View commit details
    Browse the repository at this point in the history

  2. Remove Console.ReadLine with Sleep(-1)

    @davidfowl
    davidfowl committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    3f51943 View commit details
    Browse the repository at this point in the history