Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Always build with hot reload support (in a component) #54124

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

lambdageek
Copy link
Member

Get rid of the ENABLE_METADATA_UPDATE ifdef. To disable hot reload - don't include the component in the runtime.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lambdageek lambdageek added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label Jun 13, 2021
@lambdageek lambdageek force-pushed the no-hotreload-feature-flag branch from 4f6ec6b to 3343bec Compare June 13, 2021 20:36
@lambdageek lambdageek changed the title Always build with hot reload support (in a component) [mono]Always build with hot reload support (in a component) Jun 13, 2021
@lambdageek lambdageek changed the title [mono]Always build with hot reload support (in a component) [mono] Always build with hot reload support (in a component) Jun 13, 2021
Get rid of the ENABLE_METADATA_UPDATE ifdef.  To disable hot reload,
don't include the component in the runtime
@lambdageek lambdageek force-pushed the no-hotreload-feature-flag branch from 3343bec to 225f224 Compare June 13, 2021 20:44
@marek-safar marek-safar merged commit 8818fb0 into dotnet:main Jun 14, 2021
@lambdageek lambdageek mentioned this pull request Jun 15, 2021
51 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants