Throw ArgumentNull instead of NullReference for null requests #53742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsIf someone inherits from
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone inherits from
HttpClientHandlerand calls into baseSend/SendAsyncwith a null request, they would see a NRE (since null checks happen inHttpClient).The only test around this was for
DiagnosticsHandler.This PR adds the null checks to underlying handlers and moves the test to the default
HttpClientHandler.When experimenting around
DiagnosticsHandler, this test was annoying me sinceSocketsHttpHandlerdidn't have a null check and it's kind of arbitrary that the test exists only for 1 handler.