Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArPow stage 1: local source-build infrastructure #53294
ArPow stage 1: local source-build infrastructure #53294
Changes from 34 commits
1054536
7d0c956
376c10c
8a4c258
9d474ce
06f1d5e
0e4d155
cc4124f
59fb50e
ad4201b
1c87b39
c4f711d
479c95a
2565431
cd313cd
2b5307d
d7546c5
d6602eb
843caa7
a7d8b95
18d9616
f8e8475
aa13d3c
38cea15
f5445ee
4d94fd4
0a8059d
9b2c5b3
1b2d9b1
23e4735
5a12eaf
e0c3357
658dea4
de586df
e9b7fe4
469f6a1
6c2e477
1c97495
e6f5d8f
f026627
371a532
58bb935
309421d
7230fa1
972035a
f905b0e
0124b4f
cf48c62
4211c03
88a1715
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - I logged an issue for having the ArPOW infrastructure handle large packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to better understand why these categories are necessary? We don't have a categorization today in the repo and hard coding all the produced assets for source build isn't really maintainable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the background on this - dotnet/source-build#2034 and https://github.com/dotnet/source-build/blob/main/Documentation/planning/arcade-powered-source-build/intermediate-nupkg.md#too-large. The driving reason a single intermediate NuGet package is too large to publish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our discussion earlier today I updated the split to be chunkier until the Arcade changes are in-place to handle splitting the artifacts automatically. There are only three packages produced now, two being the supplemental ones.
371M Microsoft.SourceBuild.Intermediate.runtime.runtime.linux-x64.6.0.0-dev.nupkg
319M Microsoft.SourceBuild.Intermediate.runtime.linux-x64.6.0.0-dev.nupkg
357M Microsoft.SourceBuild.Intermediate.runtime.Crossgen2Pack.linux-x64.6.0.0-dev.nupkg