FileStream rewrite: Use IValueTaskSource instead of TaskCompletionSource#50802

Merged

carlossanlop merged 19 commits intodotnet:mainfrom carlossanlop:IValueTaskSource

Apr 15, 2021

+579-355

Commits on Apr 13, 2021

Remove IFileStreamCompletionStrategy. This makes FileStreamCompletionSource only needed by Net5CompatFileStreamStrategy.
carlossanlop
committed
Use AwaitableProvider for AsyncWindowsFileStreamStrategy.
carlossanlop
committed
No need for ManualResetValueTaskSource class. Remove it to get rid of one allocation and get the actual profiling improvement.
carlossanlop
committed
Bring back ReadAsync/WriteAsync code to the strategy for simpler code review. Shorter filename for awaitable provider.
carlossanlop
committed
FileStreamCompletionSource can now be nested in Net5CompatFileStreamStrategy, and its _fileHandle can now be private.
carlossanlop
committed
Remove duplicate error definitions, use centralized Interop.Errors.
carlossanlop
committed
Move shared mask values to FileStreamHelpers to avoid duplication.
carlossanlop
committed
Use Interop.Errors also in SyncWindowsFileStreamStrategy.
carlossanlop
committed
Move misplaced comment, move method location.
carlossanlop
committed
Slightly better comment.
carlossanlop
committed
Rename FileStreamAwaitableProvider to FileStreamValueTaskSource to keep in sync with the name of FileStreamCompletionSource.
carlossanlop
committed
Bring back the raw pointer intOverlapped.
carlossanlop
committed
Rename MemoryAwaitableProvider to MemoryFileStreamValueTaskSource.
carlossanlop
committed
Remove numBufferedBytes and avoid unnecessary allocation in Read(byte[],int,int).
carlossanlop
committed
Rename files of nested types.
carlossanlop
committed
Nested async result codes in static class.
carlossanlop
committed
Address feedback.
carlossanlop
committed
Address suggestions
carlossanlop
committed

Commits on Apr 15, 2021

Bring back RunContinuationAsynchronously=true
carlossanlop
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FileStream rewrite: Use IValueTaskSource instead of TaskCompletionSource#50802

Commits on Apr 13, 2021

Remove IFileStreamCompletionStrategy. This makes FileStreamCompletionSource only needed by Net5CompatFileStreamStrategy.

Use AwaitableProvider for AsyncWindowsFileStreamStrategy.

No need for ManualResetValueTaskSource class. Remove it to get rid of one allocation and get the actual profiling improvement.

Bring back ReadAsync/WriteAsync code to the strategy for simpler code review. Shorter filename for awaitable provider.

FileStreamCompletionSource can now be nested in Net5CompatFileStreamStrategy, and its _fileHandle can now be private.

Remove duplicate error definitions, use centralized Interop.Errors.

Move shared mask values to FileStreamHelpers to avoid duplication.

Use Interop.Errors also in SyncWindowsFileStreamStrategy.

Move misplaced comment, move method location.

Slightly better comment.

Rename FileStreamAwaitableProvider to FileStreamValueTaskSource to keep in sync with the name of FileStreamCompletionSource.

Bring back the raw pointer intOverlapped.

Rename MemoryAwaitableProvider to MemoryFileStreamValueTaskSource.

Remove numBufferedBytes and avoid unnecessary allocation in Read(byte[],int,int).

Rename files of nested types.

Nested async result codes in static class.

Address feedback.

Address suggestions

Commits on Apr 15, 2021

Bring back RunContinuationAsynchronously=true