Fix some linker annotations in S.CM.TypeConverter #50593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern Issue DetailsFor #48527 (comment)
|
safern
reviewed
Apr 1, 2021
...ibraries/System.ComponentModel.TypeConverter/src/ILLink/ILLink.Suppressions.LibraryBuild.xml
Outdated
Show resolved
Hide resolved
pgovind
commented
Apr 1, 2021
| @@ -50,8 +50,6 @@ public static void Serialize(Stream o, string cryptoKey, DesigntimeLicenseContex | |||
| } | |||
| } | |||
|
|
|||
| [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode", | |||
There was a problem hiding this comment.
Remove them please. We can add them back if/when we need them.
eerhardt
approved these changes
Apr 2, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #48527 (comment)
cc @jkotas