Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to stop the Host when one of its BackgroundService instances errors #50569

Merged
merged 17 commits into from
Apr 16, 2021
Merged

Add the ability to stop the Host when one of its BackgroundService instances errors #50569

merged 17 commits into from
Apr 16, 2021

Commits on Mar 31, 2021

  1. Added background service exception behavior enum. Update HostOptions … 

    …and Host accordingly.
    @IEvangelist
    IEvangelist committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    3173bd7 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Added corresponding unit tests for host when ignoring or stopping.

    @IEvangelist
    IEvangelist committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    91a31ec View commit details
    Browse the repository at this point in the history

  2. Call StopAsync rather than FailFast

    @IEvangelist
    IEvangelist committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    a49fde9 View commit details
    Browse the repository at this point in the history

  3. Manually update String.resx outside of VS GUI

    @IEvangelist
    IEvangelist committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    2e611e1 View commit details
    Browse the repository at this point in the history

  4. Remove the RemoteExecutor, as it is no longer needed.

    @IEvangelist
    IEvangelist committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    0819a2d View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Call IApplicationLifetime.StopApplication() instead of StopAsync().

    @IEvangelist
    IEvangelist committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    e985ec5 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Moved enum out of abstractions. Encapsulate logging logic in extensio… 

    …ns. Define new EventId. Simplify check, avoid null eval. Update triple dash comments per peer review.
    @IEvangelist
    IEvangelist committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    28ccffc View commit details
    Browse the repository at this point in the history

  2. Set the default as StopHost

    @IEvangelist
    IEvangelist committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    c9356b8 View commit details
    Browse the repository at this point in the history

  3. Move ref bits from hosting.abstractions to hosting proper.

    @IEvangelist
    IEvangelist committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    4632446 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Address feedback from peer review

    @IEvangelist
    IEvangelist committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    a74d694 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Added unit test to verify background service 1 gets started, and runs… 

    … a bit - and other service can cause stop
    @IEvangelist
    IEvangelist committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    4737d98 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Use explicitly controlled timing for unit test and remove args: ex

    @IEvangelist
    IEvangelist committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    5cd1705 View commit details
    Browse the repository at this point in the history

  2. Convert from Fact, to Theory. Test both enum values.

    @IEvangelist
    IEvangelist committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    bad7af5 View commit details
    Browse the repository at this point in the history

  3. Adjusted test case, per @eerhardt

    @IEvangelist
    IEvangelist committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    aeb6a56 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Fix test hang issue

    @IEvangelist
    IEvangelist committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    d9c642d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Separate StartAsync and ExecuteTask, let StartAsync bubble. Adjust un… 

    …it tests...
    @IEvangelist
    IEvangelist committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    71c1f26 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Update the background service async exceptions get logged unit test

    @IEvangelist
    IEvangelist committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    3d4c11c View commit details
    Browse the repository at this point in the history