Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Fix debugger tests #49206

Merged
merged 3 commits into from
Mar 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/mono/mono/mini/mini-wasm-debugger.c
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,9 @@ describe_object_properties_for_klass (void *obj, MonoClass *klass, gboolean isAs
continue;
}

if (p->get->flags & METHOD_ATTRIBUTE_STATIC)
continue;

EM_ASM ({
MONO.mono_wasm_add_properties_var ($0, { field_offset: $1, is_own: $2, attr: $3, owner_class: $4 });
}, p->name, pnum, is_own, p->attrs, klass_name);
Expand Down
6 changes: 4 additions & 2 deletions src/mono/wasm/debugger/BrowserDebugHost/Startup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,10 @@ async Task ConnectProxy(HttpContext context)
var endpoint = new Uri($"ws://{devToolsHost.Authority}{context.Request.Path}");
try
{
using ILoggerFactory loggerFactory = LoggerFactory.Create(
builder => builder.AddConsole().AddFilter(null, LogLevel.Information));
using ILoggerFactory loggerFactory = LoggerFactory.Create(builder =>
builder.AddSimpleConsole(options => options.SingleLine = true)
.AddFilter(null, LogLevel.Information)
);

context.Request.Query.TryGetValue("urlSymbolServer", out StringValues urlSymbolServerList);
var proxy = new DebuggerProxy(loggerFactory, urlSymbolServerList.ToList());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,9 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Net.WebSockets;
using System.Reflection;
using System.Text;
using System.Text.RegularExpressions;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging;
using Microsoft.WebAssembly.Diagnostics;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
Expand Down Expand Up @@ -430,7 +426,6 @@ internal async Task<JObject> SendCommandAndCheck(JObject args, string method, st
AssertEqual(function_name, wait_res["callFrames"]?[0]?["functionName"]?.Value<string>(), top_frame?.ToString());
}

Console.WriteLine(top_frame);
if (script_loc != null && line >= 0)
CheckLocation(script_loc, line, column, scripts, top_frame["location"]);

Expand Down
5 changes: 3 additions & 2 deletions src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ public Inspector()
_cancellationTokenSource = new CancellationTokenSource();
Token = _cancellationTokenSource.Token;

_loggerFactory = LoggerFactory.Create(
builder => builder.AddConsole().AddFilter(null, LogLevel.Trace));
_loggerFactory = LoggerFactory.Create(builder =>
builder.AddSimpleConsole(options => options.SingleLine = true)
.AddFilter(null, LogLevel.Trace));

Client = new InspectorClient(_loggerFactory.CreateLogger<InspectorClient>());
_logger = _loggerFactory.CreateLogger<Inspector>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ public static Task Start(string chromePath, string appPath, string pagePath)
})
.ConfigureLogging(logging =>
{
logging.AddConsole();
logging.AddSimpleConsole(options => options.SingleLine = true)
.AddFilter(null, LogLevel.Information);
})
.ConfigureServices((ctx, services) =>
{
Expand Down
2 changes: 1 addition & 1 deletion src/mono/wasm/debugger/DebuggerTestSuite/Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ await CompareObjectPropertiesFor(frame_locals, "dto",
Day = TNumber(2),
Year = TNumber(2020),
DayOfWeek = TEnum("System.DayOfWeek", "Thursday")
}, "dto_props", num_fields: 22);
}, "dto_props", num_fields: 20);

var DT = new DateTime(2004, 10, 15, 1, 2, 3);
var DTO = new DateTimeOffset(dt0, new TimeSpan(2, 14, 0));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ class ClassWithProperties
public DateTime[] DTArray { get { return new DateTime[] { new DateTime(6, 7, 8, 9, 10, 11), new DateTime(1, 2, 3, 4, 5, 6) }; } }
public DateTime DTAutoProperty { get; set; }
public string StringField;

private static DateTime PrivateStaticDTProp => new DateTime(6, 5, 4, 3, 2, 1);
public static DateTime PublicStaticDTProp => new DateTime(3, 6, 1, 7, 9, 4);
}

struct StructWithProperties
Expand All @@ -71,5 +74,8 @@ struct StructWithProperties
public DateTime[] DTArray { get { return new DateTime[] { new DateTime(6, 7, 8, 9, 10, 11), new DateTime(1, 2, 3, 4, 5, 6) }; } }
public DateTime DTAutoProperty { get; set; }
public string StringField;

private static DateTime PrivateStaticDTProp => new DateTime(6, 5, 4, 3, 2, 1);
public static DateTime PublicStaticDTProp => new DateTime(3, 6, 1, 7, 9, 4);
}
}