[wasm] Improve AOT builds #48718
Closed
[wasm] Improve AOT builds #48718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The reason for this change is that generating the app bundle is optional now. Eg. in case of blazor, which handles the layout itself. - In that case, the assemblies will be used for other things during `WasmBuildApp` target (eg. AOT). - Change the name to reflect that
This was added earlier to support blazor workload which only uses AOT. But that has since been fixed to correctly use `WasmBuildApp`+`@(WasmNativeAsset)`, so this can be removed.
This fixes emcc invocations with paths that have spaces (common on windows!).
|
Tagging subscribers to this area: @directhex Issue Details
|
|
This extracts changes from #48500 except the assembly skipping part. |
pranavkm
reviewed
Feb 24, 2021
| @@ -12,24 +12,24 @@ various properties before the target `WasmBuildApp` gets executed. | |||
| to do that. | |||
|
|
|||
| - By default, the `WasmLoadAssembliesAndReferences` task is not run, and | |||
| the specified `@(WasmAssembliesToBundle)` are directly passed to | |||
| the specified `@(WasmAssembly)` are directly passed to | |||
There was a problem hiding this comment.
WasmAOTAssembly? WasmAssembly feels very non-specific.
Co-authored-by: Pranav K <prkrishn@hotmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emccinvocations, to work better with paths containing spaces