Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unknown placeholder for collectible class typehandle #48707

Merged

Conversation

AndyAyersMS
Copy link
Member

instead of null, so that we won't over-estimate likelihood of other types at a
call site where we see both collectible and non-collectible types.

Addresses part of #48549.

instead of null, so that we won't over-estimate likelihood of other types at a
call site where we see both collectible and non-collectible types.

Addresses part of dotnet#48549.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 24, 2021
@AndyAyersMS
Copy link
Member Author

cc @davidwrighton

@AndyAyersMS
Copy link
Member Author

@davidwrighton can you take a look? -- this is the simple version.

Base automatically changed from master to main March 1, 2021 09:08
@AndyAyersMS
Copy link
Member Author

@dotnet/jit-contrib anyone up for taking a look? It is a simple change.

@AndyAyersMS AndyAyersMS merged commit a43deba into dotnet:main Mar 3, 2021
@AndyAyersMS AndyAyersMS deleted the ProperlyRecordCollectibleHandle branch March 3, 2021 19:58
@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Mar 24, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants