New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 48403 - Assertion failed 'call->gtControlExpr == nullptr' #48503

Merged

briansull merged 1 commit into dotnet:master from briansull:issue-48403

Feb 25, 2021

Contributor

briansull commented Feb 19, 2021 •

edited

Loading

In method fgMorphCopyBlock don't call gtCloneExpr on the addrSpill
We also don't call fgMorphTree on the addrSpill tree as well

dotnet-issue-labeler bot added the area-CodeGen-coreclr label

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

briansull force-pushed the issue-48403 branch from 7674ddb to 4ca9c14 Compare

February 19, 2021 22:22

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

briansull linked an issue

that may be closed by this pull request

Assertion failed 'call->gtControlExpr == nullptr' in 'System.Text.Json.JsonParameterInfo1[Nullable1] #48403

Closed

AndyAyersMS reviewed

View reviewed changes

Member

AndyAyersMS left a comment

The morph changes seem unrelated to fixing the assert. Should they be PR'd separately?

src/coreclr/jit/gentree.cpp Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

JulieLeeMSFT assigned briansull

JulieLeeMSFT added this to the 6.0.0 milestone

This comment has been minimized.

Sign in to view

briansull force-pushed the issue-48403 branch from c27e3bf to 84ed691 Compare

February 24, 2021 23:11

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

briansull force-pushed the issue-48403 branch from 84ed691 to 6a7cacd Compare

February 25, 2021 01:14


          New fix for issue 48403

214cb53

 - Don't use gtCloneExpr on trees that have persistent side effects
 - Don't call gtCloneTree or fgMorpgTree when we have an addrSpill case

briansull force-pushed the issue-48403 branch from 6a7cacd to 214cb53 Compare

February 25, 2021 05:53

Contributor Author

briansull commented Feb 25, 2021

/azp run runtime-coreclr jitstress

azure-pipelines bot commented Feb 25, 2021

Azure Pipelines successfully started running 1 pipeline(s).

runfoapp bot mentioned this pull request

NuGet restore failure reading feed information #43696

Closed

Contributor Author

briansull commented Feb 25, 2021

I have reworked this fix.
It is now a minimal fix that fixes the issue.

In method fgMorphCopyBlock don't call gtCloneExpr on the addrSpill
We also don't call fgMorphTree on the addrSpill tree as well

This is ready for checkin now.
@AndyAyersMS @sandreenko PTAL

AndyAyersMS approved these changes

View reviewed changes

Member

AndyAyersMS left a comment

LGTM.

Thanks for reconsidering how to fix this.

Contributor Author

briansull commented Feb 25, 2021

The only failures that I see in the JitStress runs are due to
eventpipe\eventsvalidation\ThreadPool\ThreadPool.cmd

Which is a currently known issue: #48727

briansull merged commit 9cfe696 into dotnet:master

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr