Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-remove NetEventSource.IsEnabled property #47917

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

stephentoub
Copy link
Member

We'd removed this almost a year ago, but it came back almost immediately and accidentally as a result of two PRs that raced with each other.

cc: @eerhardt

@ghost
Copy link

ghost commented Feb 5, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

We'd removed this almost a year ago, but it came back almost immediately and accidentally as a result of two PRs that raced with each other.

cc: @eerhardt

Author: stephentoub
Assignees: -
Labels:

area-System.Net

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for fixing this.

We'd removed this almost a year ago, but it came back almost immediately and accidentally as a result of two PRs that raced with each other.
@stephentoub stephentoub merged commit 98a02e9 into dotnet:master Feb 6, 2021
@stephentoub stephentoub deleted the isenabled branch February 6, 2021 12:47
@stephentoub stephentoub added the size-reduction Issues impacting final app size primary for size sensitive workloads label Feb 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 9, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants