-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move statics to POH #47651
Move statics to POH #47651
Conversation
@@ -124,7 +124,7 @@ inline void FATAL_GC_ERROR() | |||
|
|||
#define CARD_BUNDLE //enable card bundle feature.(requires WRITE_WATCH) | |||
|
|||
// #define ALLOW_REFERENCES_IN_POH //Allow POH objects to contain references. | |||
#define ALLOW_REFERENCES_IN_POH //Allow POH objects to contain references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to have negative performance effect on POH?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will, a little bit. I do plan to improve this in the future so we don't take this perf hit. but the positive perf impact of this was quite significant so we are willing to take this small regression.
In reply to: 567187855 [](ancestors = 567187855)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we quantify the perf hit here? Since we expect to backport this to 5 servicing release, need to ensure it doesn't cause measurable regression for certain apps.
Tagging subscribers to this area: @dotnet/gc Issue DetailsThis change moved the array for holding the statics from LOH to POH.
|
This change moved the array for holding the statics from LOH to POH.