Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move statics to POH #47651

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Conversation

cshung
Copy link
Member

@cshung cshung commented Jan 29, 2021

This change moved the array for holding the statics from LOH to POH.

@@ -124,7 +124,7 @@ inline void FATAL_GC_ERROR()

#define CARD_BUNDLE //enable card bundle feature.(requires WRITE_WATCH)

// #define ALLOW_REFERENCES_IN_POH //Allow POH objects to contain references.
#define ALLOW_REFERENCES_IN_POH //Allow POH objects to contain references.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to have negative performance effect on POH?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will, a little bit. I do plan to improve this in the future so we don't take this perf hit. but the positive perf impact of this was quite significant so we are willing to take this small regression.


In reply to: 567187855 [](ancestors = 567187855)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we quantify the perf hit here? Since we expect to backport this to 5 servicing release, need to ensure it doesn't cause measurable regression for certain apps.

@ghost
Copy link

ghost commented Jan 30, 2021

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

This change moved the array for holding the statics from LOH to POH.

Author: cshung
Assignees: -
Labels:

area-GC-coreclr, area-VM-coreclr

Milestone: -

@jkotas jkotas requested a review from Maoni0 January 30, 2021 03:11
@cshung cshung merged commit 596ee7c into dotnet:master Feb 2, 2021
@cshung cshung deleted the public/move-static-to-poh-tip branch February 2, 2021 06:33
@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants