-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Enable MBR by default if interpreter is enabled #46842
Conversation
Tagging subscribers to this area: @CoffeeFlux Issue DetailsFor performance testing
|
8027936
to
f0bdc6b
Compare
@naricc assuming the tests here look ok, would it be possible to do a perf comparison of |
@lambdageek Yes; I should be able to do performance runs tomorrow. The runs take on the order of hours, so probably we will have the results tomorrow afternoon. The way it is setup it always runs everything in the pipeline, so we will get results for JIT, desktop interpreter, and WASM. |
f0bdc6b
to
2f8c25a
Compare
For performance testing
2f8c25a
to
b55b691
Compare
Performance runs: |
I've looked at profiles of interpreter results on I was able to identify some differences in profiles, primarily due to profiler choices around My overall conclusion is that the microbenchmark runs did not highlight actionable issues in turning on the metadata update code by default. The other PRs that came out of this perf investigation are: |
Closing this PR. it was only for the perf investigation |
Enable Mono MBR support by default.
Goal is to check that there are no perf regressions for non-MBR scenarios