-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signable single file apps on mac #46558
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke Issue DetailsAfter adding bundle data to the singlefile host, we need to patch up the file structure so it would satisfy expectations of codesign. Current approach is basically a copy of @swaroop-sridhar changes in https://github.com/dotnet/core-setup/compare/master...swaroop-sridhar:macsign?expand=1 Alternatively we could try inserting bundle data as a segment/section before
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Thanks!! |
Resolves:#3671
After adding bundle data to the singlefile host, we need to patch up the file structure so it would satisfy expectations of codesign.
The approach is basically a copy of @swaroop-sridhar changes in https://github.com/dotnet/core-setup/compare/master...swaroop-sridhar:macsign?expand=1
We are extending the size of string table in
__LINKEDIT
segment to include bundle data.This makes the bundle data to appear as a large string in a string table in otherwise compliant Mach-O file.
The approach is similar to what
codesign_alocate
itself does for the-p
option ("page align the code signature data by padding string table and changing its size"
).