Enable Supported attributes from sdk for non browser build, fix related warnings #45504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
requested review from
jeffhandley,
ViktorHofer,
Anipik,
joperezr and
safern
buyaa-n
commented
Dec 2, 2020
| @@ -22,8 +22,8 @@ | |||
| </AssemblyMetadata> | |||
| </ItemGroup> | |||
|
|
|||
| <!-- Adds SupportedOSPlatform attribute for Windows Specific libraries and Windows targets --> | |||
| <ItemGroup Condition="('$(IsWindowsSpecific)' == 'true' or '$(TargetsWindows)' == 'true') and '$(IsTestProject)' != 'true'"> | |||
There was a problem hiding this comment.
As SupportedOSPlatform("windows") for windows targets will be added by MSBuild we don't need it anymore
buyaa-n
commented
Dec 2, 2020
eng/versioning.targets
Outdated
| <Target Name="RemoveSupportedPlatformAssemblyLevelAttribute" | ||
| AfterTargets="GetAssemblyAttributes"> | ||
| <!-- Removes assembly level attributes for Browser. --> | ||
| <Target Name="RemoveSupportedPlatformAssemblyAttributeForBrowser" AfterTargets="GetAssemblyAttributes" Condition="'$(TargetFrameworkSuffix)' == 'Browser'"> |
There was a problem hiding this comment.
We will remove this rule completely after separating Unsupported on browser APIs from browser build.
buyaa-n
commented
Dec 2, 2020
| @@ -1033,23 +1033,6 @@ public QuotaControl(SecurityIdentifier querySid) : this() | |||
| QuerySid = querySid; | |||
| } | |||
|
|
|||
| public SecurityIdentifier QuerySid | |||
| { | |||
| get => _sid == null ? null : new SecurityIdentifier(_sid, 0); | |||
There was a problem hiding this comment.
Separated the section accessing windows only API
ViktorHofer
reviewed
Dec 3, 2020
buyaa-n
commented
Dec 3, 2020
ViktorHofer
approved these changes
Dec 14, 2020
Anipik
approved these changes
Dec 14, 2020
jeffhandley
approved these changes
Dec 14, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #44231 and #44257
Enabling Supported attributes from sdk for non browser builds, fix related warnings. We will enable it for browser later with different PR after separating
Unsupported on browserfiles from browser build.