[release/5.0] Set default value for value-type ctor params properly (#43831) #45457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set default value for value-type ctor params properly * Address review feedback
layomia
requested review from
ahsonkhan,
jozkee and
steveharter
as code owners
steveharter
approved these changes
Dec 7, 2020
ericstj
approved these changes
Dec 8, 2020
leecow
added
Servicing-approved
|
When is this fix going to be released? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #43831 to 5.0
Fixes #43757 in 5.0
Description
Fixes bug where a
NullReferenceExceptionis thrown when (de)serializing a type whose constructor hasdefaultis set as optional argument default for a value-typed ctor parameter. For example, this type:Customer Impact
Avoids a
NullReferenceExceptionin a potentially common scenario.Regression
Not a regression since the deserialization-with-paramterized-ctor feature is new in 5.0.
Testing
Unit tests have been added to verify the expected behavior.
Risk
Little to none. This is a very small and scoped change to address this issue only.