Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overloads for Enum.Parse/TryParse with ReadOnlySpan<char> #43255

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Add overloads for Enum.Parse/TryParse with ReadOnlySpan<char> #43255

merged 4 commits into from
Feb 26, 2021

Conversation

hrrrrustic
Copy link
Contributor

close #1916

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@hrrrrustic
Copy link
Contributor Author

@jkotas any comments/review?

@danmoseley danmoseley requested a review from joperezr October 22, 2020 20:29
@danmoseley
Copy link
Member

Tagged @joperezr as area owner.

stephentoub
stephentoub approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest this PR should include also fixing up calls to the existing overloads that should instead use the new overloads (e.g. places where we may have been trimming the input string prior to the call), but on a quick search, I didn't find any.

So, LGTM. Thanks!

@stephentoub stephentoub mentioned this pull request Feb 1, 2021
Closed
@danmoseley
Copy link
Member

@hrrrrustic we're trying to make a push to finish old PR's like this one. Are you still in a position to address feedback?

@hrrrrustic
Copy link
Contributor Author

Writing xml docs right now :)

@stephentoub
Copy link
Member

@hrrrrustic, thanks. I can review again, but there are conflicts. Would you mind rebasing on top of master?

@hrrrrustic
Copy link
Contributor Author

@stephentoub Done

@stephentoub
Copy link
Member

The PR is changing the permissions on src/installer/snaps/dotnet-sdk/dotnet-runtime. Please revert that.

@hrrrrustic
Copy link
Contributor Author

@stephentoub No idea how did I do that, but I force pushed revert. There are some failing ci, but error log is quite strange

stephentoub
stephentoub approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@hrrrrustic @stephentoub
remove extra line
cba1651 
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@stephentoub stephentoub merged commit adc2416 into dotnet:master Feb 26, 2021
@lezzi lezzi mentioned this pull request Mar 28, 2021
Open
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@terrajobst terrajobst terrajobst left review comments

@danmoseley danmoseley danmoseley left review comments

@joperezr joperezr joperezr left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

@joperezr joperezr

Labels
area-System.Runtime new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce overloads of Enum.Parse/TryParse that accept ReadOnlySpan<char>
7 participants
@hrrrrustic @Dotnet-GitSync-Bot @danmoseley @stephentoub @terrajobst @joperezr @jkotas