Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for building a test exe as single file #42972
Add option for building a test exe as single file #42972
Changes from all commits
7d639a0
690efe2
2eab45d
37cbeb8
c6bf3dc
47531d8
e3d8e2a
f04fa34
473d410
968fa5a
7daff3f
7bca7ff
ab19aa3
83e7eee
bd66b69
a9386d2
53e3958
5b04b1a
fb3239b
ea82af5
162fe9b
508ea02
7efb272
784b603
e8dfc86
bf57d34
73c8c4f
a367ee0
a47ea12
5490021
924892a
b42129c
8b733b2
1ceb9a1
6486a3a
9b36582
dc9a90f
d47b11e
a4d37ec
a3d6b3b
315958b
202daa6
2ad8175
d719b53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be missing
osx_x64
, is it by design?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some problems what I tested this earlier. Bringing Mac online would be good, but wasn't necessary for a first pass here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually try to not depend on private targets which are implementation detail and could change their name or be removed. Is there a public target that runs before this or on the chain of this target that you can hook to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at the moment, but I think we could probably add something. I'm open to adding a lot more integration points here to help with testing.