-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][tests][browser] Http - FunctionalTests - mark failing tests #42866
Conversation
I'm not sure how to change this |
Hmmm, good question. Thanks for going through these, I think we should probably annotate some of them slightly differently. I'll make a pass through. |
65c6974
to
b476bdd
Compare
@steveisok thoughts on what we should do about enabling these in the normal flow for Browser? |
You can add something like we do for System.Threading.Tasks:
|
29ac851
to
81c4ee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we really need better functional tests for browser.
Selenium error
|
- Most of these are failing due to LoopbackServer - some others are due to monitors not being supported This brings the result to zero failures: `Tests run: 439, Errors: 0, Failures: 0, Skipped: 18. Time: 2.128495s`
81c4ee7
to
fbd13ef
Compare
Failure is |
This brings the result to zero failures:
Tests run: 439, Errors: 0, Failures: 0, Skipped: 18. Time: 2.128495s