-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block casting to an interface marked ComInterfaceType.InterfaceIsIInspectable #41633
Block casting to an interface marked ComInterfaceType.InterfaceIsIInspectable #41633
Conversation
Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@AaronRobinsonMSFT I'm assuming we want to backport this to 5.0 once this merges into master? |
@jkoritzinsky Bah. Boo... I forgot the main branch is now 6. It would be nice if you could try and take it to ship room. Just the product change nothing else. I really consider this a missed scenario for our WinRT in .NET 5.0 plans. It isn't blocking anyone, but shutting down all those entry points would be ideal. |
…ky/runtime into mngd-iinspectable-iface-block
The only failure is on Mono WASM and this code only runs on Windows on CoreCLR. I'm going to merge this in. |
/backport to release/5.0 |
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/234983966 |
During the cast path, nothing checks if an interface is an IInspectable interface. This PR adds that check to ensure that we block usage of ComInterfaceType.InterfaceIsIInspectable now that WinRT support is removed.
Fixes #41621