Fix Array.Sort in the presence of nulls #41234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
svick
changed the title
jkotas
approved these changes
Aug 23, 2020
All changes go to master. We backport from master as necessary. |
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/221163831 |
|
Shoukd we have more test combinations, given this involves the complexity of pivots, etc? |
|
I added a tracking issue #41376 for adding more test combinations. |
ghost
locked as resolved and limited conversation to collaborators
DDolG
added a commit
to DDolG/runtime
that referenced
this pull request
Apr 26, 2022
*Added tests for sorting arrays *Separated tests for integer from string *Added comments for integers and strings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41235.
This was introduced by https://github.com/dotnet/runtime/pull/35297/files#diff-54c667fe59347842036834f5b31c5411L513-R477. Notice that the first
whileloop stays== null, but the second one incorrectly changes from!= nullto== null.I think this is a fairly serious bug that should be fixed in 5.0, but as I understand it, master already targets 6.0. Should I rebase and retarget this PR to the release/5.0 branch?
cc: @stephentoub