Fix crossgenning of sparse COM interface types on non-Windows and add test #40404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vtable gap members.
…nto sparse-vtable-crossgen-test
…the COM test suite.
AaronRobinsonMSFT
approved these changes
Aug 5, 2020
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
davidwrighton
approved these changes
Aug 5, 2020
|
The perf wasm leg is not supposed to run on PR (and was just moved to outerloop). Since none of the code in this PR affects anything in the perf wasm leg, I'm going to merge this once the Mono test legs that are currently running are green. |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes errors from crossgenning sparse vtable types on non-Windows platforms. Running crossgen on crossgen2 causes crossgen to try to readytorun some sparse vtables in Microsoft.DiaSymReader.dll. This change fixes crossgen to ignore these members and not error out on Linux (same behavior as Windows).
This PR also adds a test that tests sparse vtables on Windows and tests the sparse vtable crossgenning on all platforms.