[wasm] Modify System.Net.Request to throw PNSE on Browser WASM #40274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndWorkerTests.TestFinalization test
|
Tagging subscribers to this area: @safern, @ViktorHofer |
MaximLipnin
commented
Aug 3, 2020
src/libraries/System.Net.Requests/src/System.Net.Requests.csproj
Outdated
Show resolved
Hide resolved
akoeplinger
reviewed
Aug 3, 2020
src/libraries/System.Net.Requests/src/System.Net.Requests.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/tests/System.Net.Requests.Tests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
marek-safar
approved these changes
Aug 4, 2020
|
Hello @marek-safar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This was referenced Aug 4, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…t#40274) * [wasm] Modify System.Net.Request to throw PNSE on Browser WASM * [wasm] Re-enable System.ComponentModel.EventBasedAsync.Tests.BackgroundWorkerTests.TestFinalization test * Make the CS0809 build warning depend on if PNSE assembly is going to be generated * Update src/libraries/System.Net.Requests/src/System.Net.Requests.csproj Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> * Remove redundant condition Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds throwing PlatformNotSupportedException to
System.Net.Requestat assembly level.This also enables
System.ComponentModel.EventBasedAsync.Tests.BackgroundWorkerTests.TestFinalizationtest which doesn't fail locally.