Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][file system] Tests System.IO.FileSystem #39768

Merged
merged 50 commits into from
Aug 10, 2020
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
8ca1985
[browser][file system] Tests System.IO.FileSystem
kjpou1 Jul 22, 2020
2345e46
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jul 23, 2020
1726cea
Remove FileSystem from test project exclusions.
kjpou1 Jul 23, 2020
75bee0f
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jul 24, 2020
1497c02
[browser][filesystem] Comment on skipped tests due to IO.Pipes not su…
kjpou1 Jul 24, 2020
19cba4d
[browser][filesystem] Comment on skipped tests due to monitor not sup…
kjpou1 Jul 24, 2020
cb8bef8
Address review comments
kjpou1 Jul 24, 2020
ca9ab82
Address review comments on how to handle monitor PNSE
kjpou1 Jul 24, 2020
b850c07
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jul 25, 2020
2e49e46
Update src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs
kjpou1 Jul 27, 2020
0aa80e9
Merge branch 'wasm-filesystem-tests' of https://github.com/kjpou1/run…
kjpou1 Jul 27, 2020
43ca45c
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jul 27, 2020
f69b500
Add ActiveIssue for browser platform
kjpou1 Jul 27, 2020
9b5cf83
Simplify test case with `PlatformDetection.IsSuperUser` as per review…
kjpou1 Jul 27, 2020
b8c080b
Remove unused variable from tests
kjpou1 Jul 27, 2020
663355f
Browser platform volume does not limit each component of the path to …
kjpou1 Jul 27, 2020
2c682a2
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jul 28, 2020
8c9ea54
Fix windows tests
kjpou1 Jul 28, 2020
13594af
Add ActiveIssue to test System.IO.Tests.DirectoryInfo_Name.CurrentDir…
kjpou1 Jul 28, 2020
fcd5619
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jul 29, 2020
6d8a03e
Add active issue for tests that need to support file locking.
kjpou1 Jul 29, 2020
67afdd0
Add active issue for tests that need to support file locking.
kjpou1 Jul 29, 2020
987b396
Browser volume does not have a limit on segments
kjpou1 Jul 29, 2020
4b9f798
Remove browser platform test
kjpou1 Jul 29, 2020
3c247f4
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jul 30, 2020
ddace82
Remove active issue for NotFoundErrorIsExpected
kjpou1 Jul 30, 2020
3344248
Remove platform specific from SkippingHiddenFiles
kjpou1 Jul 30, 2020
72c1940
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Jul 31, 2020
a0fe67a
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Aug 3, 2020
c9294ee
Fix enumeration test errors failing from `HiddenFilesAreReturned`.
kjpou1 Aug 3, 2020
b002779
Fix enumeration test errors failing from `HiddenFilesAreReturned`.
kjpou1 Aug 3, 2020
8b2c389
Fix build for TARGET_WASM not defined
kjpou1 Aug 3, 2020
f5d769c
Address review comment by add check for IsWindows to IsSuperUser.
kjpou1 Aug 3, 2020
577c0c0
Address review comment by add check for IsWindows to IsSuperUser.
kjpou1 Aug 3, 2020
d865ea4
Platform Specific test for hidden files no longer needed.
kjpou1 Aug 3, 2020
3e53601
Platform Specific test fno longer needed.
kjpou1 Aug 3, 2020
6daf2ee
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Aug 4, 2020
db35de8
Use active issue for rename issue
kjpou1 Aug 4, 2020
9ecbb24
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
kjpou1 Aug 5, 2020
65f822b
ActiveIssue no longer needed
kjpou1 Aug 5, 2020
92090ed
Use ActiveIssue for SettingUpdatesProperties
Aug 7, 2020
bd84dfb
Use ActiveIssue for TimesIncludeMillisecondPart
Aug 7, 2020
b0821f5
Use ActiveIssue for ErrorHandlingTests failures
Aug 7, 2020
c95fb8f
Use ActiveIssue for SetUptoNanoseconds
Aug 7, 2020
a2d7e4e
Use ActiveIssue for GetSetTimes test failures
Aug 7, 2020
9a88676
Use ActiveIssue for tests failing with DirectoryNotFoundException
Aug 7, 2020
d69b7bd
Use ActiveIssue for tests failing with UnauthorizedAccessException
Aug 7, 2020
c86d12a
Remove debugging statement from pal_io
Aug 10, 2020
3ff6524
Address type in CreateDirectory method name
Aug 10, 2020
91f2561
Merge remote-tracking branch 'upstream/master' into wasm-filesystem-t…
Aug 10, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public static TimeFunction Create(SetTime setter, GetTime getter, DateTimeKind k
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void SettingUpdatesProperties()
{
T item = GetExistingItem();
Expand Down Expand Up @@ -77,6 +78,7 @@ public void CanGetAllTimesAfterCreation()
}

[ConditionalFact(nameof(isNotHFS))] // OSX HFS driver format does not support millisec granularity
[PlatformSpecific(~TestPlatforms.Browser)]
public void TimesIncludeMillisecondPart()
{
T item = GetExistingItem();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,17 +210,26 @@ public void DirectoryEqualToMaxDirectory_CanBeCreatedAllAtOnce()
Assert.Equal(path, result.FullName);
Assert.True(Directory.Exists(result.FullName));
}
#endregion

#region PlatformSpecific

[Theory,
MemberData(nameof(PathsWithComponentLongerThanMaxComponent))]
[PlatformSpecific(~TestPlatforms.Browser)] // Browser does not have a limit on the maximum component length
public void DirectoryWithComponentLongerThanMaxComponentAsPath_ThrowsException(string path)
{
AssertExtensions.ThrowsAny<IOException, DirectoryNotFoundException, PathTooLongException>(() => Create(path));
}

#endregion

#region PlatformSpecific
[Theory,
MemberData(nameof(PathsWithComponentLongerThanMaxComponent))]
[PlatformSpecific(TestPlatforms.Browser)] // Browser specific test in case the check changes in the future
public void DirectoryWithComponentLongerThanMaxComponentAsPath_BrowserDoesNotThrowsException(string path)
mdh1418 marked this conversation as resolved.
Show resolved Hide resolved
{
DirectoryInfo result = Create(path);
Assert.True(Directory.Exists(path));
}

[Theory, MemberData(nameof(PathsWithInvalidColons))]
[PlatformSpecific(TestPlatforms.Windows)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ public void RecursiveDelete()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void RecursiveDeleteWithTrailingSlash()
{
DirectoryInfo testDir = Directory.CreateDirectory(GetTestFilePath());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ public void SubdirectoryOnNonExistentDriveAsPath_ReturnsFalse()
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Makes call to native code (libc)
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Makes call to native code (libc)
public void FalseForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ public void TrailingSlashes()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void HiddenFilesAreReturned()
{
// Note that APIs that take EnumerationOptions do NOT find hidden files by default
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.IO.FileSystem/tests/Directory/Move.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public void EmptyPath()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
kjpou1 marked this conversation as resolved.
Show resolved Hide resolved
public void NonExistentDirectory()
{
DirectoryInfo valid = Directory.CreateDirectory(GetTestFilePath());
Expand Down Expand Up @@ -173,6 +174,7 @@ public void DirectoryNameWithSpaces()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void TrailingDirectorySeparators()
{
string testDirSource = Path.Combine(TestDirectory, GetTestFileName());
Expand Down Expand Up @@ -200,6 +202,7 @@ public void IncludeSubdirectories()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void Path_Longer_Than_MaxLongPath_Throws_Exception()
{
string testDir = GetTestFilePath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public void FalseForFile()
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Uses P/Invokes
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Uses P/Invokes
public void FalseForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ protected virtual void Move(DirectoryInfo sourceDir, string destDir)
#region UniversalTests

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here

public void DirectoryPathUpdatesOnMove()
{
//NOTE: MoveTo adds a trailing separator character to the FullName of a DirectoryInfo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace System.IO.Tests
public class DirectoryInfo_Name : FileSystemTest
{
[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void CurrentDirectory()
{
var info = new DirectoryInfo(".");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ public void OpenErrorDoesNotHappenAgainOnMoveNext()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/39955", TestPlatforms.Browser)]
public void NotFoundErrorIsExpected()
{
// Make sure we're returning the native error as expected (and not the PAL error on Unix)
Expand Down Expand Up @@ -99,6 +100,7 @@ public void DeleteDirectoryAfterOpening()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void VariableLengthFileNames_AllCreatableFilesAreEnumerable()
{
DirectoryInfo testDirectory = Directory.CreateDirectory(GetTestFilePath());
Expand All @@ -116,6 +118,7 @@ public void VariableLengthFileNames_AllCreatableFilesAreEnumerable()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void VariableLengthDirectoryNames_AllCreatableDirectoriesAreEnumerable()
{
DirectoryInfo testDirectory = Directory.CreateDirectory(GetTestFilePath());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ protected virtual string[] GetPaths(string directory, EnumerationOptions options
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void SkippingHiddenFiles()
{
DirectoryInfo testDirectory = Directory.CreateDirectory(GetTestFilePath());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ protected virtual string[] GetNames(string directory, EnumerationOptions options
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void SkippingHiddenFiles()
{
// Files that begin with periods are considered hidden on Unix
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem/tests/File/Copy.cs
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ public static IEnumerable<object[]> CopyFileWithData_MemberData()

[Theory]
[MemberData(nameof(CopyFileWithData_MemberData))]
[PlatformSpecific(~TestPlatforms.Browser)]
public void CopyFileWithData(char[] data, bool readOnly)
{
string testFileSource = GetTestFilePath();
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.IO.FileSystem/tests/File/Create.cs
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ public void InvalidDirectory()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void FileInUse()
{
DirectoryInfo testDir = Directory.CreateDirectory(GetTestFilePath());
Expand Down Expand Up @@ -145,6 +146,7 @@ public void OverwriteReadOnly()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void LongPathSegment()
{
DirectoryInfo testDir = Directory.CreateDirectory(GetTestFilePath());
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/File/Exists.cs
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ public void DirectoryWithComponentLongerThanMaxComponentAsPath_ReturnsFalse(stri
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Uses P/Invokes
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Uses P/Invokes
public void FalseForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
3 changes: 2 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class File_GetSetTimes : StaticGetSetTimes
{
// OSX has the limitation of setting upto 2262-04-11T23:47:16 (long.Max) date.
// 32bit Unix has time_t up to ~ 2038.
private static bool SupportsLongMaxDateTime => PlatformDetection.IsWindows || (RuntimeInformation.ProcessArchitecture != Architecture.Arm && RuntimeInformation.ProcessArchitecture != Architecture.X86 && !PlatformDetection.IsOSXLike);
private static bool SupportsLongMaxDateTime => PlatformDetection.IsWindows || (!PlatformDetection.Is32BitProcess && !PlatformDetection.IsOSXLike);

protected override string GetExistingItem()
{
Expand Down Expand Up @@ -135,6 +135,7 @@ public void SetLastWriteTimeTicks()
}

[ConditionalFact(nameof(isNotHFS))] // OSX HFS driver format does not support nanosecond granularity.
[PlatformSpecific(~TestPlatforms.Browser)]
public void SetUptoNanoseconds()
{
string file = GetTestFilePath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public void Overwrite()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void OpenFile_ThrowsIOException()
{
string path = GetTestFilePath();
Expand All @@ -106,7 +107,7 @@ public void WriteToReadOnlyFile()
try
{
// Operation succeeds when being run by the Unix superuser
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && geteuid() == 0)
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser)
kjpou1 marked this conversation as resolved.
Show resolved Hide resolved
{
File.WriteAllBytes(path, Encoding.UTF8.GetBytes("text"));
Assert.Equal(Encoding.UTF8.GetBytes("text"), File.ReadAllBytes(path));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public async Task OverwriteAsync()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public async Task OpenFile_ThrowsIOExceptionAsync()
{
string path = GetTestFilePath();
Expand All @@ -120,7 +121,7 @@ public async Task WriteToReadOnlyFileAsync()
try
{
// Operation succeeds when being run by the Unix superuser
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && geteuid() == 0)
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser)
{
await File.WriteAllBytesAsync(path, Encoding.UTF8.GetBytes("text"));
Assert.Equal(Encoding.UTF8.GetBytes("text"), await File.ReadAllBytesAsync(path));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ public virtual void Overwrite()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void OpenFile_ThrowsIOException()
{
string path = GetTestFilePath();
Expand Down Expand Up @@ -112,7 +113,7 @@ public void WriteToReadOnlyFile()
try
{
// Operation succeeds when being run by the Unix superuser
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && geteuid() == 0)
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser)
{
Write(path, new string[] { "text" });
Assert.Equal(new string[] { "text" }, Read(path));
Expand Down Expand Up @@ -267,6 +268,7 @@ public virtual void Overwrite()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void OpenFile_ThrowsIOException()
{
string path = GetTestFilePath();
Expand Down Expand Up @@ -300,7 +302,7 @@ public void WriteToReadOnlyFile()
try
{
// Operation succeeds when being run by the Unix superuser
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && geteuid() == 0)
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser)
{
Write(path, new string[] { "text" });
Assert.Equal(new string[] { "text" }, Read(path));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public virtual async Task OverwriteAsync()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public async Task OpenFile_ThrowsIOExceptionAsync()
{
string path = GetTestFilePath();
Expand Down Expand Up @@ -107,7 +108,7 @@ public async Task WriteToReadOnlyFile()
try
{
// Operation succeeds when being run by the Unix superuser
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && geteuid() == 0)
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser)
{
await WriteAsync(path, new string[] { "text" });
Assert.Equal(new string[] { "text" }, await ReadAsync(path));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ public virtual void Overwrite()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public void OpenFile_ThrowsIOException()
{
string path = GetTestFilePath();
Expand Down Expand Up @@ -119,7 +120,7 @@ public void WriteToReadOnlyFile()
try
{
// Operation succeeds when being run by the Unix superuser
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && geteuid() == 0)
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser)
{
Write(path, "text");
Assert.Equal("text", Read(path));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public virtual async Task OverwriteAsync()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)]
public async Task OpenFile_ThrowsIOExceptionAsync()
{
string path = GetTestFilePath();
Expand Down Expand Up @@ -115,7 +116,7 @@ public async Task WriteToReadOnlyFileAsync()
try
{
// Operation succeeds when being run by the Unix superuser
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && geteuid() == 0)
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser)
{
await WriteAsync(path, "text");
Assert.Equal("text", await ReadAsync(path));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void FalseForDirectory()
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Uses P/Invokes
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Uses P/Invokes
public void TrueForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ public override IEnumerable<TimeFunction> TimeFunctions(bool requiresRoundtrippi
}

[ConditionalFact(nameof(isNotHFS))]
[PlatformSpecific(~TestPlatforms.Browser)]
public void CopyToMillisecondPresent()
{
FileInfo input = GetNonZeroMilliseconds();
Expand All @@ -118,6 +119,7 @@ public void CopyToMillisecondPresent()
}

[ConditionalFact(nameof(isNotHFS))]
[PlatformSpecific(~TestPlatforms.Browser)]
public void CopyToNanosecondsPresent()
{
FileInfo input = GetNonZeroNanoseconds();
Expand Down Expand Up @@ -160,6 +162,7 @@ public void MoveToMillisecondPresent_HFS()
}

[ConditionalFact(nameof(isNotHFS))]
[PlatformSpecific(~TestPlatforms.Browser)]
public void MoveToMillisecondPresent()
{
FileInfo input = GetNonZeroMilliseconds();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public void CanSeekFalseForDisposedStream()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)] // IO.Pipes not supported
public void CanSeekReturnsFalseForPipe()
{
using (var pipeStream = new AnonymousPipeServerStream())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ public static IEnumerable<object[]> File_AllDataCopied_MemberData()

[Theory]
[InlineData(10, 1024)]
[PlatformSpecific(~TestPlatforms.Browser)] // IO.Pipes not supported
public async Task AnonymousPipeViaFileStream_AllDataCopied(int writeSize, int numWrites)
{
long totalLength = writeSize * numWrites;
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.IO.FileSystem/tests/FileStream/Flush.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

namespace System.IO.Tests
{
[PlatformSpecific(~TestPlatforms.Browser)]
public partial class FileStream_Flush : FileSystemTest
{
[Theory]
Expand Down Expand Up @@ -135,6 +136,7 @@ public void FlushCallsFlush_flushToDisk_False()
[InlineData(null)]
[InlineData(false)]
[InlineData(true)]
[PlatformSpecific(~TestPlatforms.Browser)] // IO.Pipes not supported
public void FlushCanBeUsedOnPipes_Success(bool? flushToDisk)
{
using (var pipeStream = new AnonymousPipeServerStream(PipeDirection.In))
Expand Down
Loading