[wasm] Address System.Text.RegularExpressions.Tests Failures #39470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdh1418
added
arch-wasm
99 tasks
eerhardt
reviewed
Jul 16, 2020
src/libraries/System.Text.RegularExpressions/tests/RegexMatchTimeoutExceptionTests.cs
Outdated
Show resolved
Hide resolved
akoeplinger
reviewed
Jul 16, 2020
src/libraries/System.Text.RegularExpressions/tests/RegexCultureTests.cs
Outdated
Show resolved
Hide resolved
mdh1418
force-pushed
the
mdhwang/address_system_text_regex_tests
branch
from
01c4ebe
to
f1cdb0f
Compare
safern
reviewed
Jul 17, 2020
src/libraries/System.Text.RegularExpressions/tests/RegexCultureTests.cs
Outdated
Show resolved
Hide resolved
mdh1418
force-pushed
the
mdhwang/address_system_text_regex_tests
branch
from
8654aee
to
226c336
Compare
mdh1418
force-pushed
the
mdhwang/address_system_text_regex_tests
branch
from
226c336
to
689033f
Compare
safern
reviewed
Jul 17, 2020
| @@ -867,6 +867,7 @@ public static IEnumerable<object[]> Groups_CustomCulture_TestData_AzeriLatin() | |||
| [MemberData(nameof(Groups_CustomCulture_TestData_Danish))] | |||
| [MemberData(nameof(Groups_CustomCulture_TestData_Turkish))] | |||
| [MemberData(nameof(Groups_CustomCulture_TestData_AzeriLatin))] | |||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/39528", TestPlatforms.Browser)] | |||
There was a problem hiding this comment.
I think this is because of the locales we support in WASM. See: #39528 (comment)
There was a problem hiding this comment.
I see, so that test case can just be skipped for browser via if (PlatformDetection.IsNotBrowser)?
There was a problem hiding this comment.
I think so. I'll let @EgorBo confirm.
There was a problem hiding this comment.
I think you can allow everything but [MemberData(nameof(Groups_CustomCulture_TestData_AzeriLatin))] now
mdh1418
changed the title
mdh1418
force-pushed
the
mdhwang/address_system_text_regex_tests
branch
from
689033f
to
03a5e09
Compare
safern
approved these changes
Jul 20, 2020
lewing
approved these changes
Jul 20, 2020
akoeplinger
approved these changes
Jul 20, 2020
|
Test failure is known: #38942 |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…39470) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #38422
Tests run: 6671, Errors: 0, Failures: 0, Skipped: 12. Time: 15.42393s