-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM: enable System.Runtime.Tests #39344
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
So I tried running this locally (on top of master) and apart from the four test failures in
Not sure why CI didn't hit this, I assume you didn't see it as well? |
I ran them on Debug and had a passing assembly. Now will run them in release to investigate the failures I'm seeing on CI and I'll let you know if I see that as well. |
The nullableattribute and nullablecontextattribute were stripped from some assemblies that reference S.P.CoreLib from runtime. That's why the cc: @eerhardt could you please review? |
Test failures are known. |
* WASM: fix System.Runtime.Tests * Enable System.Runtime.Tests * Disable test and don't strip link attributes on all product assemblies * PR feedback
* WASM: enable System.Runtime.Tests (#39344) * WASM: fix System.Runtime.Tests * Enable System.Runtime.Tests * Disable test and don't strip link attributes on all product assemblies * PR feedback * Disable System.Runtime tests that use binary formatter on wasm
Contributes to: #38422
cc: @akoeplinger @steveisok @marek-safar @tarekgh