Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM: enable System.Runtime.Tests #39344

Merged
merged 6 commits into from
Jul 16, 2020

Conversation

safern
Copy link
Member

@safern safern commented Jul 15, 2020

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern safern added arch-wasm WebAssembly architecture area-System.Runtime labels Jul 15, 2020
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/libraries/Common/tests/Tests/System/StringTests.cs Outdated Show resolved Hide resolved
@akoeplinger
Copy link
Member

akoeplinger commented Jul 15, 2020

So I tried running this locally (on top of master) and apart from the four test failures in System.Runtime.Tests.NullableMetadataTests that CI also shows I hit this runtime crash in System.Reflection.Tests.InvokeRefReturnNetcoreTests.TestNullRefReturnOfPointer:

WASM-ERR: * Assertion at /Users/alexander/dev/runtime/src/mono/mono/metadata/object.c:5740, condition `<disabled>' not met
WASM-ERR:
ABORT: undefined
Stacktrace:

Error
    at Object.onAbort (runtime.js:160:13)
    at abort (dotnet.js:1:14661)
    at _abort (dotnet.js:1:103699)
    at wasm_logger (<anonymous>:wasm-function[2885]:0x8b82e)
    at eglib_log_adapter (<anonymous>:wasm-function[5439]:0xebfe2)
    at monoeg_g_logstr (<anonymous>:wasm-function[4056]:0xae19f)
    at monoeg_g_logv_nofree (<anonymous>:wasm-function[1986]:0x57aeb)
    at monoeg_assertion_message (<anonymous>:wasm-function[375]:0xbcfa)
    at mono_assertion_message (<anonymous>:wasm-function[187]:0x4e5e)
    at mono_assertion_message_disabled (<anonymous>:wasm-function[112]:0x2fbd)
    at mono_runtime_try_invoke_array (<anonymous>:wasm-function[4281]:0xb49cc)
    at ves_icall_InternalInvoke (<anonymous>:wasm-function[3580]:0x9b970)
    at ves_icall_InternalInvoke_raw (<anonymous>:wasm-function[3579]:0x9b439)
    at do_icall (<anonymous>:wasm-function[5458]:0xed07b)
    at do_icall_wrapper (<anonymous>:wasm-function[1723]:0x499c1)
    at interp_exec_method (<anonymous>:wasm-function[1244]:0x2b455)
    at interp_runtime_invoke (<anonymous>:wasm-function[5026]:0xd53fd)
    at mono_jit_runtime_invoke (<anonymous>:wasm-function[4524]:0xbf26b)
    at do_runtime_invoke (<anonymous>:wasm-function[1722]:0x4990a)
    at mono_runtime_invoke_checked (<anonymous>:wasm-function[337]:0xab61)
    at mono_runtime_try_invoke_array (<anonymous>:wasm-function[4281]:0xb4831)
    at ves_icall_InternalInvoke (<anonymous>:wasm-function[3580]:0x9b970)
    at ves_icall_InternalInvoke_raw (<anonymous>:wasm-function[3579]:0x9b439)
    at do_icall (<anonymous>:wasm-function[5458]:0xed07b)
    at do_icall_wrapper (<anonymous>:wasm-function[1723]:0x499c1)
    at interp_exec_method (<anonymous>:wasm-function[1244]:0x2b455)
    at interp_runtime_invoke (<anonymous>:wasm-function[5026]:0xd53fd)
    at mono_jit_runtime_invoke (<anonymous>:wasm-function[4524]:0xbf26b)
    at do_runtime_invoke (<anonymous>:wasm-function[1722]:0x4990a)
    at mono_runtime_try_invoke (<anonymous>:wasm-function[434]:0xe4f0)
    at mono_runtime_invoke (<anonymous>:wasm-function[4286]:0xb4b96)
    at mono_wasm_invoke_method (<anonymous>:wasm-function[4089]:0xaee84)
    at Module._mono_wasm_invoke_method (dotnet.js:1:185998)
    at Object.init (runtime.js:354:15)
    at runtime.js:233:9
    at dotnet.js:1:126531

Not sure why CI didn't hit this, I assume you didn't see it as well?

@safern
Copy link
Member Author

safern commented Jul 15, 2020

I ran them on Debug and had a passing assembly. Now will run them in release to investigate the failures I'm seeing on CI and I'll let you know if I see that as well.

@safern
Copy link
Member Author

safern commented Jul 15, 2020

The nullableattribute and nullablecontextattribute were stripped from some assemblies that reference S.P.CoreLib from runtime. That's why the NullableMetadataTests were failing.

cc: @eerhardt could you please review?

@safern
Copy link
Member Author

safern commented Jul 16, 2020

Test failures are known. Browser failures are unrelated and @akoeplinger is currently investigating. I'll open an issue.

@safern safern merged commit 423e164 into dotnet:master Jul 16, 2020
@safern safern deleted the wasm-enablesystemruntimetests branch July 16, 2020 20:46
safern added a commit to safern/runtime that referenced this pull request Jul 16, 2020
* WASM: fix System.Runtime.Tests

* Enable System.Runtime.Tests

* Disable test and don't strip link attributes on all product assemblies

* PR feedback
safern added a commit that referenced this pull request Jul 17, 2020
* WASM: enable System.Runtime.Tests (#39344)

* WASM: fix System.Runtime.Tests

* Enable System.Runtime.Tests

* Disable test and don't strip link attributes on all product assemblies

* PR feedback

* Disable System.Runtime tests that use binary formatter on wasm
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants