Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Add support for UnmanagedCallersOnlyAttribute #38728

Merged
merged 27 commits into from
Jul 10, 2020
Merged

[mono] Add support for UnmanagedCallersOnlyAttribute #38728

merged 27 commits into from
Jul 10, 2020

Commits on Jul 8, 2020

  1. [marshal] Add mono_method_has_unmanaged_callers_only_attribute

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    e6009c9 View commit details
    Browse the repository at this point in the history

  2. [marshal] Allow calls to mono_marshal_get_managed_wrapped without a d… 

    …elegate

class

In that case, create a wrapper based on the signature of the method itself.

TODO:
 - check that the method is static
 - check that the method does not have any marshal info
   (currently it's assumed to not be present and ignored)
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4156eff View commit details
    Browse the repository at this point in the history

  3. [aot] Allow decode_method_ref to decode NATIVE_TO_MANAGED wrappers wi… 

    …thout a

delegate class

Bump the AOT file format
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a8d4d57 View commit details
    Browse the repository at this point in the history

  4. [mini] return ptr to wrapper in mono_ldftn for UnmanagedCallersOnly m… 

    …ethods
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    40662c4 View commit details
    Browse the repository at this point in the history

  5. [interp] ldftn will return a native-to-managed wrapper to UnmanagedCa… 

    …llersOnly methods
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    92ef04c View commit details
    Browse the repository at this point in the history

  6. [tests] Temporarily set UnmanagedCallersOnly tests to Pri0

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    36ebfaa View commit details
    Browse the repository at this point in the history

  7. fixup build

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    376db97 View commit details
    Browse the repository at this point in the history

  8. fixup null

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    ff12195 View commit details
    Browse the repository at this point in the history

  9. aot: emit byte when we don't expect a class

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    04b6da5 View commit details
    Browse the repository at this point in the history

  10. jit: move wrapper creation to method-to-ir, not mono_ldftn 

    Do it at IR generation of the caller, not every time the ldftn is executed
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    3ef4363 View commit details
    Browse the repository at this point in the history

  11. fix typo

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    1f6d260 View commit details
    Browse the repository at this point in the history

  12. don't get callconv from Invoke if there's no invoke

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    2579230 View commit details
    Browse the repository at this point in the history

  13. jit: don't create a jump trampoline for ldftn of a native-to-managed … 

    …wrapper

The wrapper might be called from a thread that's not attached to the runtime,
and the jump trampoline will look at TLS vars that are not initialized
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    00ed38d View commit details
    Browse the repository at this point in the history

  14. interp: transform LDFTN into LDC of a create_method_pointer for Unman… 

    …agedCallersOnly method
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b100d40 View commit details
    Browse the repository at this point in the history

  15. remove obsolete comment

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7b00b07 View commit details
    Browse the repository at this point in the history

  16. marshal: throw invalid program exception for instance and generic met… 

    …hods
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    6340c36 View commit details
    Browse the repository at this point in the history

  17. Emit IPE throw instead of aborting JIT or interp compilation for bad … 

    …UnmanagedCallersOnly methods

Instead of throwing while JITing (or transforming), throw when the LDFTN is
executed.
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a7199ad View commit details
    Browse the repository at this point in the history

  18. Use domain mempool for IPE error message

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d6b9c56 View commit details
    Browse the repository at this point in the history

  19. disallow delegate constructor calls on UnmanagedCallersOnly methods

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    1b5422f View commit details
    Browse the repository at this point in the history

  20. throw IPE if UnmanagedCallersOnly method has non-blittable args

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    6e85742 View commit details
    Browse the repository at this point in the history

  21. disallow DllImport and UnmanagedCallersOnly together 

    throw NotSupportedException
    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    9d502c5 View commit details
    Browse the repository at this point in the history

  22. Change UnamangedCallersOnlyTest.csproj back to Pri1

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    70075a9 View commit details
    Browse the repository at this point in the history

  23. Apply suggestions from code review 

    Co-authored-by: Ryan Lucia <ryan@luciaonline.net>
    @lambdageek @CoffeeFlux
    lambdageek and CoffeeFlux committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    025dd73 View commit details
    Browse the repository at this point in the history

  24. System.Char isn't blittable

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0e6f067 View commit details
    Browse the repository at this point in the history

  25. fixup non-blittable exception message

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a2f0d94 View commit details
    Browse the repository at this point in the history

  26. non-netcore doesn't have UnmanagedCallersOnlyAttribute

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    89c8c28 View commit details
    Browse the repository at this point in the history

  27. remove dead code

    @lambdageek
    lambdageek committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    ee50f3e View commit details
    Browse the repository at this point in the history