Remove assert in PEFile::GetAssemblyLoadContext #38212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method can return NULL for System.Private.CoreLib during early runtime initialization stage when the underlying AssemblyLoadContext doesn't exist yet.
|
Tagging subscribers to this area: @vitek-karas |
|
cc: @trylek |
jkotas
reviewed
Jun 22, 2020
| PTR_AssemblyLoadContext GetAssemblyLoadContext() | ||
| { | ||
| LIMITED_METHOD_CONTRACT; | ||
|
|
||
| _ASSERTE(m_pAssemblyLoadContext != NULL); |
There was a problem hiding this comment.
I think this assert is good and it should stay.
Would it be possible to call AppDomain::GetCurrentDomain()->CreateBinderContext() instead of AppDomain::GetCurrentDomain()->GetTPABinderContext() in SetupAssemblyLoadContext; and also delete the null checked for GetAssemblyLoadContext returning NULL from AcquireCompositeImage ?
There was a problem hiding this comment.
That could work, I'll give it a try.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method can return NULL for System.Private.CoreLib during early
runtime initialization stage when the underlying AssemblyLoadContext
doesn't exist yet.