Update UnmanagedCallersOnlyAttribute API surface #37843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Jun 13, 2020
jkotas
reviewed
Jun 13, 2020
UnmanagedCallersOnlyAttribute.
jkotas
reviewed
Jun 13, 2020
|
@jkotas @jkoritzinsky @elinor-fung Please take a look at this change. I have confirmed with @333fred the Roslyn side is satisfied with the current API shape. |
jkotas
reviewed
Jun 20, 2020
|
Is there a matching change that needs to be done in Mono? |
I can't find any usage of |
|
cc @lambdageek |
jkotas
reviewed
Jun 20, 2020
jkotas
reviewed
Jun 20, 2020
|
@jkotas @lambdageek @elinor-fung @jkoritzinsky any other comments? |
jkotas
approved these changes
Jun 22, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37612
/cc @jkotas @333fred @jkoritzinsky @elinor-fung