Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.editorconfig: replace invalid refactoring severity #37367

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jun 3, 2020

Valid severity levels are: error, warning, suggestion, silent, none:
https://docs.microsoft.com/visualstudio/ide/editorconfig-language-conventions?view=vs-2019#severity-levels

refactoring severity is only valid in the following context:
dotnet_naming_rule.<namingRuleTitle>.severity = refactoring
https://docs.microsoft.com/visualstudio/ide/editorconfig-naming-conventions?view=vs-2019#severity

@ghost
Copy link

ghost commented Jun 3, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 3, 2020

Thanks, curious how did you notice the invalid values?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 3, 2020

@ViktorHofer Was picked up in review here: PowerShell/PowerShell#12871 (comment)

Additionally, Visual Studio was underlining a few occurrences with a green squiggle. 😀

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 3, 2020

CI failure is #35068

@xtqqczze
Copy link
Contributor Author

@ViktorHofer Can you help merge?

@ViktorHofer
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer ViktorHofer merged commit e45d130 into dotnet:master Jun 15, 2020
@ViktorHofer
Copy link
Member

Thanks @xtqqczze :)

@xtqqczze xtqqczze deleted the editorconfig-severity branch June 15, 2020 14:00
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants