Fix fast tail calls on Windows ARM64. #37192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
|
@BruceForstall @dotnet/jit-contrib PTAL |
jakobbotsch
approved these changes
May 30, 2020
erozenfeld
force-pushed
the
FixArm64TailCall
branch
from
180d33c
to
32cc969
Compare
erozenfeld
changed the title
jkotas
reviewed
May 30, 2020
src/coreclr/src/jit/lower.cpp
Outdated
| @@ -1883,7 +1883,7 @@ void Lowering::LowerFastTailCall(GenTreeCall* call) | |||
| continue; | |||
| } | |||
|
|
|||
| #if defined(TARGET_WINDOWS) && defined(TARGET_64BIT) | |||
| #if defined(TARGET_WINDOWS) && defined(TARGET_AMD64) | |||
| // On Win64, the argument position determines the stack slot uniquely, and even the | |||
jashook
approved these changes
May 30, 2020
LowerFastTailCall has code that looks for incoming stack arguments that may be overwritten by outgoing stack arguments and copies them to a temp. The logic was incorrect for Windows Arm64 because it was assuming shadow space, which only exists in Windows x64 abi. Fixes dotnet#31729. Fixes dotnet#36911.
erozenfeld
force-pushed
the
FixArm64TailCall
branch
from
32cc969
to
6db5321
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LowerFastTailCall has code that looks for incoming stack arguments
that may be overwritten by outgoing stack arguments and copies
them to a temp. The logic was incorrect for Windows Arm64 because it was
assuming shadow space, which only exists in Windows x64 abi.
Fixes #31729.
Fixes #36911.