-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSPlatform entries for iOS/tvOS/watchOS/Android #36704
Merged
akoeplinger
merged 3 commits into
dotnet:master
from
akoeplinger:osplatform-ios-android
Jul 10, 2020
Merged
Add OSPlatform entries for iOS/tvOS/watchOS/Android #36704
akoeplinger
merged 3 commits into
dotnet:master
from
akoeplinger:osplatform-ios-android
Jul 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the non-controversial new OSPlatform members from dotnet#33331
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
stephentoub
reviewed
May 20, 2020
....InteropServices.RuntimeInformation/ref/System.Runtime.InteropServices.RuntimeInformation.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 20, 2020
...vices.RuntimeInformation/src/System/Runtime/InteropServices/RuntimeInformation/OSPlatform.cs
Show resolved
Hide resolved
The APIs were approved in #33331. |
stephentoub
approved these changes
Jul 9, 2020
stephentoub
reviewed
Jul 9, 2020
...vices.RuntimeInformation/src/System/Runtime/InteropServices/RuntimeInformation/OSPlatform.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the new OSPlatform members from #33331